diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-01-08 06:08:05 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-01-08 06:08:05 +0300 |
| commit | 30010b161d42bdac3ab5cd16e63cc61c2f4939f3 (patch) | |
| tree | 57d1392d4d668d9369f0bd1bf7a42876d6f59506 /doc/development/code_review.md | |
| parent | 2b3bfe8fc59ed4cdc385955cdb38cbd481b45426 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 445feba384b..4bc963222f2 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -314,7 +314,7 @@ experience, refactors the existing code). Then: - Ensure the target branch is not too far behind master. If [master is red](https://about.gitlab.com/handbook/engineering/workflow/#broken-master), it should be no more than 100 commits behind. -- Consider warnings and errors from danger bot, codequality, and other reports. +- Consider warnings and errors from danger bot, code quality, and other reports. Unless a strong case can be made for the violation, these should be resolved before merge. - Ensure a passing CI pipeline or if [master is broken](https://about.gitlab.com/handbook/engineering/workflow/#broken-master), post a comment mentioning the failure happens in master with a |