diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-15 18:42:17 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-15 18:42:17 +0300 |
| commit | 44fdf983bd35328dd577d3d3650d14163ef3e2b6 (patch) | |
| tree | 84ff300d056cfbabb5a0fe2a9cbaa80aaeab1cc5 /doc/development/code_review.md | |
| parent | bc9fa07b26184b5c94808f704db6ea1ac81bf4de (diff) | |
Add latest changes from gitlab-org/gitlab@12-10-stable-ee
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 52a0672259f..5220f29bd60 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -490,15 +490,11 @@ A good example of collaboration on an MR touching multiple parts of the codebase ### Credits -Largely based on the [thoughtbot code review guide]. - -[thoughtbot code review guide]: https://github.com/thoughtbot/guides/tree/master/code-review +Largely based on the [thoughtbot code review guide](https://github.com/thoughtbot/guides/tree/master/code-review). --- [Return to Development documentation](README.md) -[projects]: https://about.gitlab.com/handbook/engineering/projects/ -[build handbook]: https://about.gitlab.com/handbook/build/handbook/build#how-to-work-with-build [^1]: Please note that specs other than JavaScript specs are considered backend code. [^2]: We encourage you to seek guidance from a database maintainer if your merge request is potentially introducing expensive queries. It is most efficient to comment on the line of code in question with the SQL queries so they can give their advice. |