diff options
| author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-12-02 10:55:53 +0300 |
|---|---|---|
| committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-12-02 10:55:53 +0300 |
| commit | ebef1a8441b451e2718860538c6e6261ea616bf8 (patch) | |
| tree | a613e456768955dc1539a69bc855f522f5cfbb22 /doc/development/code_review.md | |
| parent | 85c4aa4a6725407a90f8b313488584f193e1b55a (diff) | |
Remove change to MWBS in code review guideline
[ci skip]
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 52ee633c43a..e1fb8102b67 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -70,7 +70,7 @@ experience, refactors the existing code). Then: - After a round of line notes, it can be helpful to post a summary note such as "LGTM :thumbsup:", or "Just a couple things to address." - Avoid accepting a merge request before the build succeeds. Of course, "Merge - When Pipeline Succeeds" is fine. + When Build Succeeds" (MWBS) is fine. - If you set the MR to "Merge When Build Succeeds", you should take over subsequent revisions for anything that would be spotted after that. |