diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-19 12:08:42 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-19 12:08:42 +0300 |
| commit | b76ae638462ab0f673e5915986070518dd3f9ad3 (patch) | |
| tree | bdab0533383b52873be0ec0eb4d3c66598ff8b91 /doc/development/experiment_guide | |
| parent | 434373eabe7b4be9593d18a585fb763f1e5f1a6f (diff) | |
Add latest changes from gitlab-org/gitlab@14-2-stable-eev14.2.0-rc42
Diffstat (limited to 'doc/development/experiment_guide')
| -rw-r--r-- | doc/development/experiment_guide/gitlab_experiment.md | 8 | ||||
| -rw-r--r-- | doc/development/experiment_guide/index.md | 1 |
2 files changed, 5 insertions, 4 deletions
diff --git a/doc/development/experiment_guide/gitlab_experiment.md b/doc/development/experiment_guide/gitlab_experiment.md index 33222b0492c..1cd3fefb7cf 100644 --- a/doc/development/experiment_guide/gitlab_experiment.md +++ b/doc/development/experiment_guide/gitlab_experiment.md @@ -492,12 +492,12 @@ expect(subject).to track(:my_event) subject.track(:my_event) ``` -You can use the `on_any_instance` chain method to specify that it could happen on -any instance of the experiment. This helps you if you're calling +You can use the `on_next_instance` chain method to specify that it will happen +on the next instance of the experiment. This helps you if you're calling `experiment(:example).track` downstream: ```ruby -expect(experiment(:example)).to track(:my_event).on_any_instance +expect(experiment(:example)).to track(:my_event).on_next_instance experiment(:example).track(:my_event) ``` @@ -506,7 +506,7 @@ A full example of the methods you can chain onto the `track` matcher: ```ruby expect(experiment(:example)).to track(:my_event, value: 1, property: '_property_') - .on_any_instance + .on_next_instance .with_context(foo: :bar) .for(:variant_name) diff --git a/doc/development/experiment_guide/index.md b/doc/development/experiment_guide/index.md index 798c6ff84d0..e4a97091a81 100644 --- a/doc/development/experiment_guide/index.md +++ b/doc/development/experiment_guide/index.md @@ -63,6 +63,7 @@ Therefore, you should postpone this effort until the [experiment cleanup process We recommend the following workflow: +1. Review the Pajamas guidelines for [icons](https://design.gitlab.com/product-foundations/iconography) and [illustrations](https://design.gitlab.com/product-foundations/illustration). 1. Add an icon or illustration as an `.svg` file in the `/app/assets/images` (or EE) path in the GitLab repository. 1. Use `image_tag` or `image_path` to render it via the asset pipeline. 1. **If the experiment is a success**, designers add the new icon or illustration to the Pajamas UI kit as part of the cleanup process. |