diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-20 21:38:24 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-20 21:38:24 +0300 |
| commit | 983a0bba5d2a042c4a3bbb22432ec192c7501d82 (patch) | |
| tree | b153cd387c14ba23bd5a07514c7c01fddf6a78a0 /doc/development/logging.md | |
| parent | a2bddee2cdb38673df0e004d5b32d9f77797de64 (diff) | |
Add latest changes from gitlab-org/gitlab@12-10-stable-ee
Diffstat (limited to 'doc/development/logging.md')
| -rw-r--r-- | doc/development/logging.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/development/logging.md b/doc/development/logging.md index f10737da766..ef2d2d7022d 100644 --- a/doc/development/logging.md +++ b/doc/development/logging.md @@ -164,6 +164,14 @@ Resources: - [Elasticsearch mapping - avoiding type gotchas](https://www.elastic.co/guide/en/elasticsearch/guide/current/mapping.html#_avoiding_type_gotchas) - [Elasticsearch mapping types]( https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html) +#### Logging durations + +Similar to timezones, choosing the right time unit to log can impose avoidable overhead. So, whenever +challenged to choose between seconds, milliseconds or any other unit, lean towards _seconds_ as float. + +In order to make it easier to track timings in the logs, make sure the log key has `_s` as +suffix and `duration` within its name (e.g., `view_duration_s`). + ## Multi-destination Logging GitLab is transitioning from unstructured/plaintext logs to structured/JSON logs. During this transition period some logs will be recorded in multiple formats through multi-destination logging. |