diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-12 03:10:06 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-12 03:10:06 +0300 |
| commit | 50de2638aa79ec022a7c95a96ecfe5a4f8ef177a (patch) | |
| tree | 062b7a8d821ff0252340c3300e7ddd2ed296f6f0 /doc/development/service_ping/implement.md | |
| parent | 3ecbefc5818c1ca6b4ce54ac8afa148eac7bfdb2 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/service_ping/implement.md')
| -rw-r--r-- | doc/development/service_ping/implement.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/service_ping/implement.md b/doc/development/service_ping/implement.md index 6625f4e33fe..48bcc07f4e7 100644 --- a/doc/development/service_ping/implement.md +++ b/doc/development/service_ping/implement.md @@ -605,7 +605,7 @@ alt_usage_data(value = nil, fallback: -1, &block) Arguments: -- `value`: a simple static value in which case the value is simply returned. +- `value`: a static value in which case the value is returned. - or a `block`: which is evaluated - `fallback: -1`: the common value used for any metrics that are failing. @@ -714,7 +714,7 @@ We also use `#database-lab` and [explain.depesz.com](https://explain.depesz.com/ - [Example 2](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26445) - Use defined `start` and `finish`, and simple queries. These values can be memoized and reused, as in this [example merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37155). -- Avoid joins and write the queries as simply as possible, +- Avoid joins and write the queries as clearly as possible, as in this [example merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36316). - Set a custom `batch_size` for `distinct_count`, as in this [example merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38000). |