diff options
| author | Mark Lapierre <mlapierre@gitlab.com> | 2019-08-29 09:22:58 +0300 |
|---|---|---|
| committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-09-04 02:24:10 +0300 |
| commit | 88b727d7b7b6de4e388dba77cf05a3cfa26e8d7b (patch) | |
| tree | caa8c789839a947cc559744388b2928a027e718b /doc/development/testing_guide | |
| parent | 34357e03866e73c17df60ba003d46482193cbcd4 (diff) | |
CE backport of EE MR approvals E2E test
Includes API methods to add members to projects and groups
Diffstat (limited to 'doc/development/testing_guide')
| -rw-r--r-- | doc/development/testing_guide/end_to_end/page_objects.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/development/testing_guide/end_to_end/page_objects.md b/doc/development/testing_guide/end_to_end/page_objects.md index 850ea6b60ac..8820b54fa87 100644 --- a/doc/development/testing_guide/end_to_end/page_objects.md +++ b/doc/development/testing_guide/end_to_end/page_objects.md @@ -167,6 +167,18 @@ There are two supported methods of defining elements within a view. Any existing `.qa-selector` class should be considered deprecated and we should prefer the `data-qa-selector` method of definition. +### Exceptions + +In some cases it might not be possible or worthwhile to add a selector. + +Some UI components use external libraries, including some maintained by third parties. +Even if a library is maintained by GitLab, the selector sanity test only runs +on code within the GitLab project, so it's not possible to specify the path for +the view for code in a library. + +In such rare cases it's reasonable to use CSS selectors in page object methods, +with a comment explaining why an `element` can't be added. + ## Running the test locally During development, you can run the `qa:selectors` test by running |