diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-08 09:09:54 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-04-08 09:09:54 +0300 |
| commit | f6cdec670b9b757fc2225a2c6627ab79765e5b8a (patch) | |
| tree | 7a1fde030f117b69332d01b22deefd1c81fff458 /doc/development/uploads.md | |
| parent | e2ee1eec50aa8df8543d7ecc585ec0ba5ee544ac (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/uploads.md')
| -rw-r--r-- | doc/development/uploads.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/uploads.md b/doc/development/uploads.md index b26211901b2..fbdb15d82e1 100644 --- a/doc/development/uploads.md +++ b/doc/development/uploads.md @@ -1,7 +1,7 @@ # Uploads development documentation [GitLab Workhorse](https://gitlab.com/gitlab-org/gitlab-workhorse) has special rules for handling uploads. -To prevent occupying a ruby process on I/O operations, we process the upload in workhorse, where is cheaper. +To prevent occupying a Ruby process on I/O operations, we process the upload in workhorse, where is cheaper. This process can also directly upload to object storage. ## The problem description @@ -40,7 +40,7 @@ We have three challenges here: performance, availability, and scalability. ### Performance -Rails process are expensive in terms of both CPU and memory. Ruby [global interpreter lock](https://en.wikipedia.org/wiki/Global_interpreter_lock) adds to cost too because the ruby process will spend time on I/O operations on step 3 causing incoming requests to pile up. +Rails process are expensive in terms of both CPU and memory. Ruby [global interpreter lock](https://en.wikipedia.org/wiki/Global_interpreter_lock) adds to cost too because the Ruby process will spend time on I/O operations on step 3 causing incoming requests to pile up. In order to improve this, [disk buffered upload](#disk-buffered-upload) was implemented. With this, Rails no longer deals with writing uploaded files to disk. |