diff options
| author | Nick Thomas <nick@gitlab.com> | 2019-02-05 20:16:18 +0300 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2019-02-13 19:41:28 +0300 |
| commit | 77b2ecd2b1de3f66c3d9ebd5e58fedafb17ea606 (patch) | |
| tree | eb360eb0264b50370ff3ad48910ad437183bc3b6 /doc/development | |
| parent | 235fe67bdbc7f177a6f4b213bb1780f043944246 (diff) | |
Reviewer roulette via Danger
Make danger pick reviewers and maintainers at random, for feontend,
backend, database, etc, changes, whenever files belonging to those
teams get changed.
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 25ea2211b64..4e5fb47e331 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -23,6 +23,11 @@ one of the [Merge request coaches][team]. If you need assistance with security scans or comments, feel free to include the Security Team (`@gitlab-com/gl-security`) in the review. +The `danger-review` CI job will randomly pick a reviewer and a maintainer for +each area of the codebase that your merge request seems to touch. It only makes +recommendations - feel free to override it if you think someone else is a better +fit! + Depending on the areas your merge request touches, it must be **approved** by one or more [maintainers](https://about.gitlab.com/handbook/engineering/workflow/code-review/#maintainer): |