diff options
author | Stan Hu <stanhu@gmail.com> | 2018-11-27 19:51:34 +0300 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-11-27 19:51:34 +0300 |
commit | 681d7139a995a8d2e299c567d45c03221f89fd6f (patch) | |
tree | 2dda494cdd5d9ac0d24ea9325dadd956e16db0db /doc/development | |
parent | 17acf40dc98f05a476176dbd0b5da813be39b909 (diff) | |
parent | 7e7fb6deba4e58b4dbbb21a8e859327cebd109d1 (diff) |
Merge branch 'json-logging-for-k8s' into 'master'
Json logging for k8s Integration
See merge request gitlab-org/gitlab-ce!23328
Diffstat (limited to 'doc/development')
-rw-r--r-- | doc/development/logging.md | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/doc/development/logging.md b/doc/development/logging.md index abd08c420da..5c1d96b9e0c 100644 --- a/doc/development/logging.md +++ b/doc/development/logging.md @@ -75,7 +75,7 @@ To create a new file: module Import class Logger < ::Gitlab::JsonLogger def self.file_name_noext - 'importer_json' + 'importer' end end end @@ -105,7 +105,7 @@ To create a new file: ```ruby # GOOD - logger.info("Unable to create project", project_id: project.id) + logger.info(message: "Unable to create project", project_id: project.id) ``` 1. Be sure to create a common base structure of your log messages. For example, @@ -118,13 +118,13 @@ To create a new file: ```ruby # BAD - logger.info("Import error", error: 1) - logger.info("Import error", error: "I/O failure") + logger.info(message: "Import error", error: 1) + logger.info(message: "Import error", error: "I/O failure") ``` ```ruby # GOOD - logger.info("Import error", error_code: 1, error: "I/O failure") + logger.info(message: "Import error", error_code: 1, error: "I/O failure") ``` ## Additional steps with new log files |