diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-11-29 15:11:50 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-11-29 15:11:50 +0300 |
| commit | 86bf2dd3497f106fcb4f356fb6ed66a1d01e6a05 (patch) | |
| tree | 2ed3d8285b43119721266b95ccebb49c9e2a30d9 /doc | |
| parent | beb1963d67d764dcef210fc5fcffadbcfe71b812 (diff) | |
| parent | 62fd842c6565e95e269b80b6cb776c537484c830 (diff) | |
Merge branch 'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master'
Add RED data security requirement to code review
See merge request gitlab-org/gitlab-ce!23426
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/code_review.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 7f3d23b5fb0..8a186df7f06 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -53,6 +53,8 @@ from teams other than your own. #### Security requirements + 1. If your merge request is processing, storing, or transferring any kind of [RED or ORANGE data][https://docs.google.com/document/d/15eNKGA3zyZazsJMldqTBFbYMnVUSQSpU14lo22JMZQY/edit] (this is a confidential document), it must be + **approved by a [Security Engineer][team]**. 1. If your merge request involves implementing, utilizing, or is otherwise related to any type of authentication, authorization, or session handling mechanism, it must be **approved by a [Security Engineer][team]**. 1. If your merge request has a goal which requires a cryptographic function such as: confidentiality, integrity, authentication, or non-repudiation, it must be |