diff options
| author | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-08 16:33:36 +0300 |
|---|---|---|
| committer | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-15 14:05:14 +0300 |
| commit | 650f40865e5d8136cb366fbde689c4100aafb0c5 (patch) | |
| tree | f740d9f235693ad8e2a3693d6ec30dee26d2a74a /lib/api/projects.rb | |
| parent | 7457c1e1229cd1e90e608e8b247e2fbb217f05b6 (diff) | |
Forbid the use of `#reload` and prefer `#reset`
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
Diffstat (limited to 'lib/api/projects.rb')
| -rw-r--r-- | lib/api/projects.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/api/projects.rb b/lib/api/projects.rb index 57336e95041..cb0106592f5 100644 --- a/lib/api/projects.rb +++ b/lib/api/projects.rb @@ -351,7 +351,7 @@ module API not_modified! else current_user.toggle_star(user_project) - user_project.reload + user_project.reset present user_project, with: Entities::Project, current_user: current_user end @@ -363,7 +363,7 @@ module API post ':id/unstar' do if current_user.starred?(user_project) current_user.toggle_star(user_project) - user_project.reload + user_project.reset present user_project, with: Entities::Project, current_user: current_user else @@ -403,7 +403,7 @@ module API result = ::Projects::ForkService.new(fork_from_project, current_user).execute(user_project) if result - present user_project.reload, with: Entities::Project, current_user: current_user + present user_project.reset, with: Entities::Project, current_user: current_user else render_api_error!("Project already forked", 409) if user_project.forked? end |