diff options
| author | Toon Claes <toon@gitlab.com> | 2017-04-21 12:36:34 +0300 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2017-04-27 10:57:09 +0300 |
| commit | a204d14c672e08a825479511473ba3999ed08434 (patch) | |
| tree | 05018866869b1119b38c71a668503e91797a733b /lib/api/todos.rb | |
| parent | d031665a634e5d6fef980e837d6b227097850178 (diff) | |
Avoid plucking Todo ids and use sub-queries instead
TodoService should not call `.select(&:id)` on todos, because this is
bad performance. So instead use sub-queries, which will result in a
single SQL query to the database.
https://docs.gitlab.com/ee/development/sql.html#plucking-ids
Diffstat (limited to 'lib/api/todos.rb')
| -rw-r--r-- | lib/api/todos.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/api/todos.rb b/lib/api/todos.rb index d1f7e364029..10aa64947fe 100644 --- a/lib/api/todos.rb +++ b/lib/api/todos.rb @@ -59,10 +59,10 @@ module API requires :id, type: Integer, desc: 'The ID of the todo being marked as done' end post ':id/mark_as_done' do + TodoService.new.mark_todos_as_done_by_ids(params[:id], current_user) todo = current_user.todos.find(params[:id]) - TodoService.new.mark_todos_as_done([todo], current_user) - present todo.reload, with: Entities::Todo, current_user: current_user + present todo, with: ::API::Entities::Todo, current_user: current_user end desc 'Mark all todos as done' |