diff options
author | Jan Provaznik <jprovaznik@gitlab.com> | 2018-12-11 19:20:06 +0300 |
---|---|---|
committer | Jan Provaznik <jprovaznik@gitlab.com> | 2018-12-13 12:00:59 +0300 |
commit | ddbe6083265ed3dd9b42db2f4a982c4aa4e54b76 (patch) | |
tree | 78590dc6e9995b28be7891930bb11933f0d1bd1e /lib/banzai | |
parent | d2120ff1e705799752e7d9704cae3f1896d8e186 (diff) |
Set URL rel attribute for broken URLs
It's possible that URI fails to parse a link, but browsers
still recognize given URL as a link, we should make sure
that 'rel' attribute is set also in this case.
Diffstat (limited to 'lib/banzai')
-rw-r--r-- | lib/banzai/filter/external_link_filter.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/banzai/filter/external_link_filter.rb b/lib/banzai/filter/external_link_filter.rb index 2e6d742de27..4f60b6f84c6 100644 --- a/lib/banzai/filter/external_link_filter.rb +++ b/lib/banzai/filter/external_link_filter.rb @@ -9,11 +9,10 @@ module Banzai def call links.each do |node| uri = uri(node['href'].to_s) - next unless uri - node.set_attribute('href', uri.to_s) + node.set_attribute('href', uri.to_s) if uri - if SCHEMES.include?(uri.scheme) && external_url?(uri) + if SCHEMES.include?(uri&.scheme) && !internal_url?(uri) node.set_attribute('rel', 'nofollow noreferrer noopener') node.set_attribute('target', '_blank') end @@ -35,11 +34,12 @@ module Banzai doc.xpath(query) end - def external_url?(uri) + def internal_url?(uri) + return false if uri.nil? # Relative URLs miss a hostname - return false unless uri.hostname + return true unless uri.hostname - uri.hostname != internal_url.hostname + uri.hostname == internal_url.hostname end def internal_url |