Add specs for chain element that populates a pipeline

1 files changed, 7 insertions, 1 deletions

diff --git a/lib/gitlab/ci/pipeline/chain/populate.rb b/lib/gitlab/ci/pipeline/chain/populate.rb
index 5368ff15481..94d9b44b257 100644
--- a/lib/gitlab/ci/pipeline/chain/populate.rb
+++ b/lib/gitlab/ci/pipeline/chain/populate.rb
@@ -3,6 +3,8 @@ module Gitlab
     module Pipeline
       module Chain
         class Populate < Chain::Base
+          include Chain::Helpers
+
           PopulateError = Class.new(StandardError)
 
           def perform!
@@ -19,11 +21,15 @@ module Gitlab
               pipeline.stages << seed.to_resource
             end
 
+            if pipeline.invalid?
+              error('Failed to build the pipeline!')
+            end
+
             raise Populate::PopulateError if pipeline.persisted?
           end
 
           def break?
-            pipeline.persisted?
+            pipeline.invalid?
           end
         end
       end