Change Redis TTL to 1day. Fixing nitpicks

1 files changed, 7 insertions, 3 deletions

diff --git a/lib/gitlab/ci/trace/chunked_io.rb b/lib/gitlab/ci/trace/chunked_io.rb
index d768c011968..8dbe892df64 100644
--- a/lib/gitlab/ci/trace/chunked_io.rb
+++ b/lib/gitlab/ci/trace/chunked_io.rb
@@ -19,7 +19,7 @@ module Gitlab
           @job = job
           @chunks_cache = []
           @tell = 0
-          @size = job_chunks.last.try(&:end_offset).to_i
+          @size = calculate_size
           yield self if block_given?
         end
 
@@ -48,7 +48,7 @@ module Gitlab
               -1
             end
 
-          raise 'new position is outside of file' if new_pos < 0 || new_pos > size
+          raise ArgumentError, 'new position is outside of file' if new_pos < 0 || new_pos > size
 
           @tell = new_pos
         end
@@ -135,7 +135,7 @@ module Gitlab
         end
 
         def truncate(offset)
-          raise 'Outside of file' if offset > size
+          raise ArgumentError, 'Outside of file' if offset > size
 
           @tell = offset
           @size = offset
@@ -221,6 +221,10 @@ module Gitlab
         def job_chunks
           ::Ci::JobTraceChunk.where(job: job)
         end
+
+        def calculate_size
+          job_chunks.order(chunk_index: :desc).last.try(&:end_offset).to_i
+        end
       end
     end
   end