Fix while true

1 files changed, 8 insertions, 13 deletions

diff --git a/lib/gitlab/ci/trace/stream.rb b/lib/gitlab/ci/trace/stream.rb
index be8e40af016..72a0d669de0 100644
--- a/lib/gitlab/ci/trace/stream.rb
+++ b/lib/gitlab/ci/trace/stream.rb
@@ -117,23 +117,18 @@ module Gitlab
         end
 
         def reverse_line
-          pos = 0
+          pos = BUFFER_SIZE
           max = stream.size
 
-          while true
+          while pos < max
+            stream.seek(-pos, IO::SEEK_END)
+            yield(stream.read(BUFFER_SIZE))
             pos += BUFFER_SIZE
-
-            buf =
-              if pos <= max
-                stream.seek(-pos, IO::SEEK_END)
-                stream.read(BUFFER_SIZE)
-              else # Reached the head, read only left
-                stream.seek(0)
-                stream.read(BUFFER_SIZE - (pos - max))
-              end
-
-            yield(buf)
           end
+
+          # Reached the head, read only left
+          stream.seek(0)
+          yield(stream.read(BUFFER_SIZE - (pos - max)))
         end
       end
     end