diff options
author | Matija Čupić <matteeyah@gmail.com> | 2018-11-16 01:38:16 +0300 |
---|---|---|
committer | Matija Čupić <matteeyah@gmail.com> | 2018-12-08 21:28:54 +0300 |
commit | b6c8d3ac9f3031f6174dde2f11b3876ab4ac8a20 (patch) | |
tree | aac1eaab9045bb64503aceb4bb3f11290d6bc6b6 /lib/gitlab/ci | |
parent | b0b5924eb418851ddfab848ab16b6acac27d42e0 (diff) |
Reintroduce Command#protected_ref?
Diffstat (limited to 'lib/gitlab/ci')
-rw-r--r-- | lib/gitlab/ci/pipeline/chain/build.rb | 1 | ||||
-rw-r--r-- | lib/gitlab/ci/pipeline/chain/command.rb | 6 | ||||
-rw-r--r-- | lib/gitlab/ci/pipeline/chain/populate.rb | 5 | ||||
-rw-r--r-- | lib/gitlab/ci/pipeline/chain/validate/abilities.rb | 2 |
4 files changed, 8 insertions, 6 deletions
diff --git a/lib/gitlab/ci/pipeline/chain/build.rb b/lib/gitlab/ci/pipeline/chain/build.rb index 41632211374..d33d1edfe35 100644 --- a/lib/gitlab/ci/pipeline/chain/build.rb +++ b/lib/gitlab/ci/pipeline/chain/build.rb @@ -17,6 +17,7 @@ module Gitlab user: @command.current_user, pipeline_schedule: @command.schedule, merge_request: @command.merge_request, + protected: @command.protected_ref?, variables_attributes: Array(@command.variables_attributes) ) diff --git a/lib/gitlab/ci/pipeline/chain/command.rb b/lib/gitlab/ci/pipeline/chain/command.rb index ee5022e47c4..316c283d90b 100644 --- a/lib/gitlab/ci/pipeline/chain/command.rb +++ b/lib/gitlab/ci/pipeline/chain/command.rb @@ -51,6 +51,12 @@ module Gitlab def before_sha self[:before_sha] || checkout_sha || Gitlab::Git::BLANK_SHA end + + def protected_ref? + strong_memoize(:protected_ref) do + project.protected_for?(origin_ref) + end + end end end end diff --git a/lib/gitlab/ci/pipeline/chain/populate.rb b/lib/gitlab/ci/pipeline/chain/populate.rb index 45b4393ecf3..633d3cd4f6b 100644 --- a/lib/gitlab/ci/pipeline/chain/populate.rb +++ b/lib/gitlab/ci/pipeline/chain/populate.rb @@ -19,11 +19,6 @@ module Gitlab @command.seeds_block&.call(pipeline) ## - # Populate pipeline protected status - # - pipeline.protected = @command.project.protected_for?(@command.origin_ref) - - ## # Populate pipeline with all stages, and stages with builds. # pipeline.stage_seeds.each do |stage| diff --git a/lib/gitlab/ci/pipeline/chain/validate/abilities.rb b/lib/gitlab/ci/pipeline/chain/validate/abilities.rb index e4979102fd9..ebd7e6e8289 100644 --- a/lib/gitlab/ci/pipeline/chain/validate/abilities.rb +++ b/lib/gitlab/ci/pipeline/chain/validate/abilities.rb @@ -31,7 +31,7 @@ module Gitlab if current_user allowed_to_create? else # legacy triggers don't have a corresponding user - !@command.project.protected_for?(@command.origin_ref) + !@command.protected_ref? end end |