Avoid calling freeze on already frozen strings in lib/gitlab

6 files changed, 13 insertions, 13 deletions

diff --git a/lib/gitlab/ci/build/port.rb b/lib/gitlab/ci/build/port.rb
index 6c4656ffea2..017b31b4f77 100644
--- a/lib/gitlab/ci/build/port.rb
+++ b/lib/gitlab/ci/build/port.rb
@@ -4,8 +4,8 @@ module Gitlab
   module Ci
     module Build
       class Port
-        DEFAULT_PORT_NAME = 'default_port'.freeze
-        DEFAULT_PORT_PROTOCOL = 'http'.freeze
+        DEFAULT_PORT_NAME = 'default_port'
+        DEFAULT_PORT_PROTOCOL = 'http'
 
         attr_reader :number, :protocol, :name
 
diff --git a/lib/gitlab/ci/build/step.rb b/lib/gitlab/ci/build/step.rb
index 7fcabc035ac..48111ae5717 100644
--- a/lib/gitlab/ci/build/step.rb
+++ b/lib/gitlab/ci/build/step.rb
@@ -4,9 +4,9 @@ module Gitlab
   module Ci
     module Build
       class Step
-        WHEN_ON_FAILURE = 'on_failure'.freeze
-        WHEN_ON_SUCCESS = 'on_success'.freeze
-        WHEN_ALWAYS = 'always'.freeze
+        WHEN_ON_FAILURE = 'on_failure'
+        WHEN_ON_SUCCESS = 'on_success'
+        WHEN_ALWAYS = 'always'
 
         attr_reader :name
         attr_accessor :script, :timeout, :when, :allow_failure
diff --git a/lib/gitlab/ci/config/entry/cache.rb b/lib/gitlab/ci/config/entry/cache.rb
index 7b94af24c09..ef07c319ce4 100644
--- a/lib/gitlab/ci/config/entry/cache.rb
+++ b/lib/gitlab/ci/config/entry/cache.rb
@@ -12,7 +12,7 @@ module Gitlab
           include ::Gitlab::Config::Entry::Attributable
 
           ALLOWED_KEYS = %i[key untracked paths policy].freeze
-          DEFAULT_POLICY = 'pull-push'.freeze
+          DEFAULT_POLICY = 'pull-push'
 
           validations do
             validates :config, allowed_keys: ALLOWED_KEYS
diff --git a/lib/gitlab/ci/config/external/file/template.rb b/lib/gitlab/ci/config/external/file/template.rb
index 54f4cf74c4d..db56f6a9b00 100644
--- a/lib/gitlab/ci/config/external/file/template.rb
+++ b/lib/gitlab/ci/config/external/file/template.rb
@@ -8,7 +8,7 @@ module Gitlab
           class Template < Base
             attr_reader :location, :project
 
-            SUFFIX = '.gitlab-ci.yml'.freeze
+            SUFFIX = '.gitlab-ci.yml'
 
             def initialize(params, context)
               @location = params[:template]
diff --git a/lib/gitlab/ci/cron_parser.rb b/lib/gitlab/ci/cron_parser.rb
index 94f4a4e36c9..1d7e7ea0f9a 100644
--- a/lib/gitlab/ci/cron_parser.rb
+++ b/lib/gitlab/ci/cron_parser.rb
@@ -3,8 +3,8 @@
 module Gitlab
   module Ci
     class CronParser
-      VALID_SYNTAX_SAMPLE_TIME_ZONE = 'UTC'.freeze
-      VALID_SYNTAX_SAMPLE_CRON = '* * * * *'.freeze
+      VALID_SYNTAX_SAMPLE_TIME_ZONE = 'UTC'
+      VALID_SYNTAX_SAMPLE_CRON = '* * * * *'
 
       def initialize(cron, cron_timezone = 'UTC')
         @cron = cron
diff --git a/lib/gitlab/ci/reports/test_case.rb b/lib/gitlab/ci/reports/test_case.rb
index 292e273a03a..fdeaad698b9 100644
--- a/lib/gitlab/ci/reports/test_case.rb
+++ b/lib/gitlab/ci/reports/test_case.rb
@@ -4,10 +4,10 @@ module Gitlab
   module Ci
     module Reports
       class TestCase
-        STATUS_SUCCESS = 'success'.freeze
-        STATUS_FAILED = 'failed'.freeze
-        STATUS_SKIPPED = 'skipped'.freeze
-        STATUS_ERROR = 'error'.freeze
+        STATUS_SUCCESS = 'success'
+        STATUS_FAILED = 'failed'
+        STATUS_SKIPPED = 'skipped'
+        STATUS_ERROR = 'error'
         STATUS_TYPES = [STATUS_SUCCESS, STATUS_FAILED, STATUS_SKIPPED, STATUS_ERROR].freeze
 
         attr_reader :name, :classname, :execution_time, :status, :file, :system_output, :stack_trace, :key