more refactoring and fixing old specs

1 files changed, 3 insertions, 15 deletions

diff --git a/lib/gitlab/cycle_analytics/summary.rb b/lib/gitlab/cycle_analytics/summary.rb
index 7d172855a94..5f0103c9d5a 100644
--- a/lib/gitlab/cycle_analytics/summary.rb
+++ b/lib/gitlab/cycle_analytics/summary.rb
@@ -9,9 +9,9 @@ module Gitlab
       end
 
       def data
-        [serialize(issue),
-         serialize(commit),
-         serialize(deploy)]
+        [serialize(Summary::Issue.new(project: @project, from: @from)),
+         serialize(Summary::Commit.new(project: @project, from: @from)),
+         serialize(Summary::Deploy.new(project: @project, from: @from))]
       end
 
       private
@@ -19,18 +19,6 @@ module Gitlab
       def serialize(summary_object)
         AnalyticsSummarySerializer.new.represent(summary_object).as_json
       end
-
-      def issue
-        Summary::Issue.new(project: @project, from: @from)
-      end
-
-      def deploy
-        Summary::Deploy.new(project: @project, from: @from)
-      end
-
-      def commit
-        Summary::Commit.new(project: @project, from: @from)
-      end
     end
   end
 end