Add latest changes from gitlab-org/gitlab@13-11-stable-eev13.11.0-rc43

3 files changed, 177 insertions, 72 deletions

diff --git a/lib/gitlab/error_tracking/processor/context_payload_processor.rb b/lib/gitlab/error_tracking/processor/context_payload_processor.rb
index 5185205e94e..758f6aa11d7 100644
--- a/lib/gitlab/error_tracking/processor/context_payload_processor.rb
+++ b/lib/gitlab/error_tracking/processor/context_payload_processor.rb
@@ -9,9 +9,21 @@ module Gitlab
         # integrations are re-implemented and use Gitlab::ErrorTracking, this
         # processor should be removed.
         def process(payload)
+          return payload if ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
+
           context_payload = Gitlab::ErrorTracking::ContextPayloadGenerator.generate(nil, {})
           payload.deep_merge!(context_payload)
         end
+
+        def self.call(event)
+          return event unless ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
+
+          Gitlab::ErrorTracking::ContextPayloadGenerator.generate(nil, {}).each do |key, value|
+            event.public_send(key).deep_merge!(value) # rubocop:disable GitlabSecurity/PublicSend
+          end
+
+          event
+        end
       end
     end
   end
diff --git a/lib/gitlab/error_tracking/processor/grpc_error_processor.rb b/lib/gitlab/error_tracking/processor/grpc_error_processor.rb
index 871e9c4b7c8..419098dbd09 100644
--- a/lib/gitlab/error_tracking/processor/grpc_error_processor.rb
+++ b/lib/gitlab/error_tracking/processor/grpc_error_processor.rb
@@ -6,60 +6,126 @@ module Gitlab
       class GrpcErrorProcessor < ::Raven::Processor
         DEBUG_ERROR_STRING_REGEX = RE2('(.*) debug_error_string:(.*)')
 
-        def process(value)
-          process_first_exception_value(value)
-          process_custom_fingerprint(value)
+        def process(payload)
+          return payload if ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
 
-          value
-        end
-
-        # Sentry can report multiple exceptions in an event. Sanitize
-        # only the first one since that's what is used for grouping.
-        def process_first_exception_value(value)
-          exceptions = value.dig(:exception, :values)
-
-          return unless exceptions.is_a?(Array)
-
-          entry = exceptions.first
-
-          return unless entry.is_a?(Hash)
-
-          exception_type = entry[:type]
-          raw_message = entry[:value]
-
-          return unless exception_type&.start_with?('GRPC::')
-          return unless raw_message.present?
-
-          message, debug_str = split_debug_error_string(raw_message)
-
-          entry[:value] = message if message
-          extra = value[:extra] || {}
-          extra[:grpc_debug_error_string] = debug_str if debug_str
-        end
-
-        def process_custom_fingerprint(value)
-          fingerprint = value[:fingerprint]
-
-          return value unless custom_grpc_fingerprint?(fingerprint)
+          self.class.process_first_exception_value(payload)
+          self.class.process_custom_fingerprint(payload)
 
-          message, _ = split_debug_error_string(fingerprint[1])
-          fingerprint[1] = message if message
+          payload
         end
 
-        private
-
-        def custom_grpc_fingerprint?(fingerprint)
-          fingerprint.is_a?(Array) && fingerprint.length == 2 && fingerprint[0].start_with?('GRPC::')
-        end
-
-        def split_debug_error_string(message)
-          return unless message
-
-          match = DEBUG_ERROR_STRING_REGEX.match(message)
-
-          return unless match
-
-          [match[1], match[2]]
+        class << self
+          def call(event)
+            return event unless ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
+
+            process_first_exception_value(event)
+            process_custom_fingerprint(event)
+
+            event
+          end
+
+          # Sentry can report multiple exceptions in an event. Sanitize
+          # only the first one since that's what is used for grouping.
+          def process_first_exception_value(event_or_payload)
+            exceptions = exceptions(event_or_payload)
+
+            return unless exceptions.is_a?(Array)
+
+            exception = exceptions.first
+
+            return unless valid_exception?(exception)
+
+            exception_type, raw_message = type_and_value(exception)
+
+            return unless exception_type&.start_with?('GRPC::')
+            return unless raw_message.present?
+
+            message, debug_str = split_debug_error_string(raw_message)
+
+            set_new_values!(event_or_payload, exception, message, debug_str)
+          end
+
+          def process_custom_fingerprint(event)
+            fingerprint = fingerprint(event)
+
+            return event unless custom_grpc_fingerprint?(fingerprint)
+
+            message, _ = split_debug_error_string(fingerprint[1])
+            fingerprint[1] = message if message
+          end
+
+          private
+
+          def custom_grpc_fingerprint?(fingerprint)
+            fingerprint.is_a?(Array) && fingerprint.length == 2 && fingerprint[0].start_with?('GRPC::')
+          end
+
+          def split_debug_error_string(message)
+            return unless message
+
+            match = DEBUG_ERROR_STRING_REGEX.match(message)
+
+            return unless match
+
+            [match[1], match[2]]
+          end
+
+          # The below methods can be removed once we remove the
+          # sentry_processors_before_send feature flag, and we can
+          # assume we always have an Event object
+          def exceptions(event_or_payload)
+            case event_or_payload
+            when Raven::Event
+              # Better in new version, will be event_or_payload.exception.values
+              event_or_payload.instance_variable_get(:@interfaces)[:exception]&.values
+            when Hash
+              event_or_payload.dig(:exception, :values)
+            end
+          end
+
+          def valid_exception?(exception)
+            case exception
+            when Raven::SingleExceptionInterface
+              exception&.value
+            when Hash
+              true
+            else
+              false
+            end
+          end
+
+          def type_and_value(exception)
+            case exception
+            when Raven::SingleExceptionInterface
+              [exception.type, exception.value]
+            when Hash
+              exception.values_at(:type, :value)
+            end
+          end
+
+          def set_new_values!(event_or_payload, exception, message, debug_str)
+            case event_or_payload
+            when Raven::Event
+              # Worse in new version, no setter! Have to poke at the
+              # instance variable
+              exception.value = message if message
+              event_or_payload.extra[:grpc_debug_error_string] = debug_str if debug_str
+            when Hash
+              exception[:value] = message if message
+              extra = event_or_payload[:extra] || {}
+              extra[:grpc_debug_error_string] = debug_str if debug_str
+            end
+          end
+
+          def fingerprint(event_or_payload)
+            case event_or_payload
+            when Raven::Event
+              event_or_payload.fingerprint
+            when Hash
+              event_or_payload[:fingerprint]
+            end
+          end
         end
       end
     end
diff --git a/lib/gitlab/error_tracking/processor/sidekiq_processor.rb b/lib/gitlab/error_tracking/processor/sidekiq_processor.rb
index 272cb689ad5..93310745ece 100644
--- a/lib/gitlab/error_tracking/processor/sidekiq_processor.rb
+++ b/lib/gitlab/error_tracking/processor/sidekiq_processor.rb
@@ -8,39 +8,66 @@ module Gitlab
       class SidekiqProcessor < ::Raven::Processor
         FILTERED_STRING = '[FILTERED]'
 
-        def self.filter_arguments(args, klass)
-          args.lazy.with_index.map do |arg, i|
-            case arg
-            when Numeric
-              arg
-            else
-              if permitted_arguments_for_worker(klass).include?(i)
+        class << self
+          def filter_arguments(args, klass)
+            args.lazy.with_index.map do |arg, i|
+              case arg
+              when Numeric
                 arg
               else
-                FILTERED_STRING
+                if permitted_arguments_for_worker(klass).include?(i)
+                  arg
+                else
+                  FILTERED_STRING
+                end
               end
             end
           end
-        end
 
-        def self.permitted_arguments_for_worker(klass)
-          @permitted_arguments_for_worker ||= {}
-          @permitted_arguments_for_worker[klass] ||=
-            begin
-              klass.constantize&.loggable_arguments&.to_set
-            rescue
-              Set.new
+          def permitted_arguments_for_worker(klass)
+            @permitted_arguments_for_worker ||= {}
+            @permitted_arguments_for_worker[klass] ||=
+              begin
+                klass.constantize&.loggable_arguments&.to_set
+              rescue
+                Set.new
+              end
+          end
+
+          def loggable_arguments(args, klass)
+            Gitlab::Utils::LogLimitedArray
+              .log_limited_array(filter_arguments(args, klass))
+              .map(&:to_s)
+              .to_a
+          end
+
+          def call(event)
+            return event unless ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
+
+            sidekiq = event&.extra&.dig(:sidekiq)
+
+            return event unless sidekiq
+
+            sidekiq = sidekiq.deep_dup
+            sidekiq.delete(:jobstr)
+
+            # 'args' in this hash => from Gitlab::ErrorTracking.track_*
+            # 'args' in :job => from default error handler
+            job_holder = sidekiq.key?('args') ? sidekiq : sidekiq[:job]
+
+            if job_holder['args']
+              job_holder['args'] = filter_arguments(job_holder['args'], job_holder['class']).to_a
             end
-        end
 
-        def self.loggable_arguments(args, klass)
-          Gitlab::Utils::LogLimitedArray
-            .log_limited_array(filter_arguments(args, klass))
-            .map(&:to_s)
-            .to_a
+            event.extra[:sidekiq] = sidekiq
+
+            event
+          end
         end
 
         def process(value, key = nil)
+          return value if ::Feature.enabled?(:sentry_processors_before_send, default_enabled: :yaml)
+
           sidekiq = value.dig(:extra, :sidekiq)
 
           return value unless sidekiq