Gitlab::Git::RevList and LfsChanges use lazy popen

1 files changed, 7 insertions, 10 deletions

diff --git a/lib/gitlab/git/lfs_changes.rb b/lib/gitlab/git/lfs_changes.rb
index 2749e2e69e2..732dd5d998a 100644
--- a/lib/gitlab/git/lfs_changes.rb
+++ b/lib/gitlab/git/lfs_changes.rb
@@ -8,25 +8,22 @@ module Gitlab
 
       def new_pointers(object_limit: nil, not_in: nil)
         @new_pointers ||= begin
-          object_ids = new_objects(not_in: not_in)
-          object_ids = object_ids.take(object_limit) if object_limit
+          rev_list.new_objects(not_in: not_in, require_path: true) do |object_ids|
+            object_ids = object_ids.take(object_limit) if object_limit
 
-          Gitlab::Git::Blob.batch_lfs_pointers(@repository, object_ids)
+            Gitlab::Git::Blob.batch_lfs_pointers(@repository, object_ids)
+          end
         end
       end
 
       def all_pointers
-        object_ids = rev_list.all_objects(require_path: true)
-
-        Gitlab::Git::Blob.batch_lfs_pointers(@repository, object_ids)
+        rev_list.all_objects(require_path: true) do |object_ids|
+          Gitlab::Git::Blob.batch_lfs_pointers(@repository, object_ids)
+        end
       end
 
       private
 
-      def new_objects(not_in:)
-        rev_list.new_objects(require_path: true, lazy: true, not_in: not_in)
-      end
-
       def rev_list
         ::Gitlab::Git::RevList.new(path_to_repo: @repository.path_to_repo,
                                    newrev: @newrev)