diff options
| author | Lin Jen-Shin <godfat@godfat.org> | 2017-07-11 21:29:33 +0300 |
|---|---|---|
| committer | Lin Jen-Shin <godfat@godfat.org> | 2017-09-18 16:23:45 +0300 |
| commit | 9ae92b8caa6c11d8860f86b7d6378062215d1b72 (patch) | |
| tree | 06b7416abad46cb1dd44c19a18a7e40caed30e15 /lib/gitlab/git/popen.rb | |
| parent | 4cadf22e208e3be401824f43ab13d5e6f2ff6465 (diff) | |
Add cop to make sure we don't use ivar in a module
Diffstat (limited to 'lib/gitlab/git/popen.rb')
| -rw-r--r-- | lib/gitlab/git/popen.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/gitlab/git/popen.rb b/lib/gitlab/git/popen.rb index 25fa62ce4bd..10c15b316f5 100644 --- a/lib/gitlab/git/popen.rb +++ b/lib/gitlab/git/popen.rb @@ -13,15 +13,15 @@ module Gitlab vars = { "PWD" => path } options = { chdir: path } - @cmd_output = "" - @cmd_status = 0 + cmd_output = "" + cmd_status = 0 Open3.popen3(vars, *cmd, options) do |stdin, stdout, stderr, wait_thr| - @cmd_output << stdout.read - @cmd_output << stderr.read - @cmd_status = wait_thr.value.exitstatus + cmd_output << stdout.read + cmd_output << stderr.read + cmd_status = wait_thr.value.exitstatus end - [@cmd_output, @cmd_status] + [cmd_output, cmd_status] end end end |