Extract and memoize `user_access`

Because it is sometimes never used.

1 files changed, 9 insertions, 6 deletions

diff --git a/lib/gitlab/git_access.rb b/lib/gitlab/git_access.rb
index 4807dc9a5fb..0a19d24eb20 100644
--- a/lib/gitlab/git_access.rb
+++ b/lib/gitlab/git_access.rb
@@ -22,18 +22,13 @@ module Gitlab
     PUSH_COMMANDS = %w{ git-receive-pack }.freeze
     ALL_COMMANDS = DOWNLOAD_COMMANDS + PUSH_COMMANDS
 
-    attr_reader :actor, :project, :protocol, :user_access, :authentication_abilities
+    attr_reader :actor, :project, :protocol, :authentication_abilities
 
     def initialize(actor, project, protocol, authentication_abilities:)
       @actor    = actor
       @project  = project
       @protocol = protocol
       @authentication_abilities = authentication_abilities
-      @user_access = if ci?
-                       CiAccess.new
-                     else
-                       UserAccess.new(user, project: project)
-                     end
     end
 
     def check(cmd, changes)
@@ -244,5 +239,13 @@ module Gitlab
           nil
         end
     end
+
+    def user_access
+      @user_access ||= if ci?
+                         CiAccess.new
+                       else
+                         UserAccess.new(user, project: project)
+                       end
+    end
   end
 end