Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2018-10-17 14:33:54 +0300
committerYorick Peterse <yorickpeterse@gmail.com>2018-10-22 16:12:46 +0300
commit4b9c17f196bab6075563f62d01f9db65c1a0515c (patch)
tree03eb38b1e3264568fe049da3790c4d3cef1a3ddc /lib/gitlab/gpg.rb
parentda1a2bd6bbabac055c7f4773813d9cddf2c5f708 (diff)
Move Project#rename_repo to a service class
This moves the logic of Project#rename_repo and all methods _only_ used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically. During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users. I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments. This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
Diffstat (limited to 'lib/gitlab/gpg.rb')
0 files changed, 0 insertions, 0 deletions