Adds the Rubocop ReturnNil cop

This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points

2 files changed, 3 insertions, 3 deletions

diff --git a/lib/gitlab/legacy_github_import/client.rb b/lib/gitlab/legacy_github_import/client.rb
index bc952147667..bbdd094e33b 100644
--- a/lib/gitlab/legacy_github_import/client.rb
+++ b/lib/gitlab/legacy_github_import/client.rb
@@ -68,7 +68,7 @@ module Gitlab
       end
 
       def user(login)
-        return nil unless login.present?
+        return unless login.present?
         return @users[login] if @users.key?(login)
 
         @users[login] = api.user(login)
diff --git a/lib/gitlab/legacy_github_import/user_formatter.rb b/lib/gitlab/legacy_github_import/user_formatter.rb
index ec0e221b1ff..889e6aaa968 100644
--- a/lib/gitlab/legacy_github_import/user_formatter.rb
+++ b/lib/gitlab/legacy_github_import/user_formatter.rb
@@ -25,7 +25,7 @@ module Gitlab
       end
 
       def find_by_email
-        return nil unless email
+        return unless email
 
         User.find_by_any_email(email)
             .try(:id)
@@ -33,7 +33,7 @@ module Gitlab
 
       # rubocop: disable CodeReuse/ActiveRecord
       def find_by_external_uid
-        return nil unless id
+        return unless id
 
         identities = ::Identity.arel_table