Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2020-01-21 21:07:31 +0300
committerGitLab Bot <gitlab-bot@gitlab.com>2020-01-21 21:07:31 +0300
commitd91f5211693e913da5df110b8de841fad87e3653 (patch)
treed1483aeb8fe3d2b9579b0e44f2e74979c4b8d17a /lib/gitlab/phabricator_import
parentc859c3bfd242288065fe5e2d887f7204f09e2335 (diff)
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'lib/gitlab/phabricator_import')
-rw-r--r--lib/gitlab/phabricator_import/base_worker.rb82
-rw-r--r--lib/gitlab/phabricator_import/import_tasks_worker.rb10
2 files changed, 0 insertions, 92 deletions
diff --git a/lib/gitlab/phabricator_import/base_worker.rb b/lib/gitlab/phabricator_import/base_worker.rb
deleted file mode 100644
index d2c2ef8db48..00000000000
--- a/lib/gitlab/phabricator_import/base_worker.rb
+++ /dev/null
@@ -1,82 +0,0 @@
-# frozen_string_literal: true
-
-# All workers within a Phabricator import should inherit from this worker and
-# implement the `#import` method. The jobs should then be scheduled using the
-# `.schedule` class method instead of `.perform_async`
-#
-# Doing this makes sure that only one job of that type is running at the same time
-# for a certain project. This will avoid deadlocks. When a job is already running
-# we'll wait for it for 10 times 5 seconds to restart. If the running job hasn't
-# finished, by then, we'll retry in 30 seconds.
-#
-# It also makes sure that we keep the import state of the project up to date:
-# - It keeps track of the jobs so we know how many jobs are running for the
-# project
-# - It refreshes the import jid, so it doesn't get cleaned up by the
-# `StuckImportJobsWorker`
-# - It marks the import as failed if a job failed to many times
-# - It marks the import as finished when all remaining jobs are done
-module Gitlab
- module PhabricatorImport
- class BaseWorker
- include ApplicationWorker
- include ProjectImportOptions # This marks the project as failed after too many tries
- include Gitlab::ExclusiveLeaseHelpers
-
- feature_category :importers
-
- class << self
- def schedule(project_id, *args)
- perform_async(project_id, *args)
- add_job(project_id)
- end
-
- def add_job(project_id)
- worker_state(project_id).add_job
- end
-
- def remove_job(project_id)
- worker_state(project_id).remove_job
- end
-
- def worker_state(project_id)
- Gitlab::PhabricatorImport::WorkerState.new(project_id)
- end
- end
-
- def perform(project_id, *args)
- in_lock("#{self.class.name.underscore}/#{project_id}/#{args}", ttl: 2.hours, sleep_sec: 5.seconds) do
- project = Project.find_by_id(project_id)
- next unless project
-
- # Bail if the import job already failed
- next unless project.import_state&.in_progress?
-
- project.import_state.refresh_jid_expiration
-
- import(project, *args)
-
- # If this is the last running job, finish the import
- project.after_import if self.class.worker_state(project_id).running_count < 2
-
- self.class.remove_job(project_id)
- end
- rescue Gitlab::ExclusiveLeaseHelpers::FailedToObtainLockError
- # Reschedule a job if there was already a running one
- # Running them at the same time could cause a deadlock updating the same
- # resource
- self.class.perform_in(30.seconds, project_id, *args)
- end
-
- private
-
- def import(project, *args)
- importer_class.new(project, *args).execute
- end
-
- def importer_class
- raise NotImplementedError, "Implement `#{__method__}` on #{self.class}"
- end
- end
- end
-end
diff --git a/lib/gitlab/phabricator_import/import_tasks_worker.rb b/lib/gitlab/phabricator_import/import_tasks_worker.rb
deleted file mode 100644
index c36954a8d41..00000000000
--- a/lib/gitlab/phabricator_import/import_tasks_worker.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-module Gitlab
- module PhabricatorImport
- class ImportTasksWorker < BaseWorker
- def importer_class
- Gitlab::PhabricatorImport::Issues::Importer
- end
- end
- end
-end