diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2018-01-24 16:05:01 +0300 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2018-01-26 14:42:48 +0300 |
commit | a2618310aea7d58e52d2d29ec4871e27717eb0f0 (patch) | |
tree | 63c943c0cd428e82955574f578ef55b5c166f1e6 /lib/gitlab/popen | |
parent | 0bf918f05e827b380107d88f4592d1ceedd632f9 (diff) |
Use Process::Status rather than an integer
However keep backward compatibility
Diffstat (limited to 'lib/gitlab/popen')
-rw-r--r-- | lib/gitlab/popen/runner.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/gitlab/popen/runner.rb b/lib/gitlab/popen/runner.rb index 36284134707..f44035a48bb 100644 --- a/lib/gitlab/popen/runner.rb +++ b/lib/gitlab/popen/runner.rb @@ -20,12 +20,12 @@ module Gitlab end end - def all_good? - all_status_zero? && all_stderr_empty? + def all_success_and_clean? + all_success? && all_stderr_empty? end - def all_status_zero? - results.all? { |result| result.status.zero? } + def all_success? + results.all? { |result| result.status.success? } end def all_stderr_empty? @@ -33,12 +33,12 @@ module Gitlab end def failed_results - results.select { |result| result.status.nonzero? } + results.reject { |result| result.status.success? } end def warned_results results.select do |result| - result.status.zero? && !result.stderr.empty? + result.status.success? && !result.stderr.empty? end end end |