Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2020-01-23 18:08:46 +0300
committerGitLab Bot <gitlab-bot@gitlab.com>2020-01-23 18:08:46 +0300
commit3f9e1b261121f4dbd045341241f81b47356c99cf (patch)
tree32be23bd7fda0c3f891182f220f6d0399a1b41dd /lib/gitlab/sidekiq_middleware
parent5ad0cf26551baff8f08af8562a8d45e6ec14d71a (diff)
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'lib/gitlab/sidekiq_middleware')
-rw-r--r--lib/gitlab/sidekiq_middleware/client_metrics.rb6
-rw-r--r--lib/gitlab/sidekiq_middleware/metrics.rb2
2 files changed, 5 insertions, 3 deletions
diff --git a/lib/gitlab/sidekiq_middleware/client_metrics.rb b/lib/gitlab/sidekiq_middleware/client_metrics.rb
index cd11415b55e..245a1b5e024 100644
--- a/lib/gitlab/sidekiq_middleware/client_metrics.rb
+++ b/lib/gitlab/sidekiq_middleware/client_metrics.rb
@@ -9,8 +9,10 @@ module Gitlab
@metrics = init_metrics
end
- def call(worker, _job, queue, _redis_pool)
- labels = create_labels(worker.class, queue)
+ def call(worker_class, _job, queue, _redis_pool)
+ # worker_class can either be the string or class of the worker being enqueued.
+ worker_class = worker_class.safe_constantize if worker_class.respond_to?(:safe_constantize)
+ labels = create_labels(worker_class, queue)
@metrics.fetch(ENQUEUED).increment(labels, 1)
diff --git a/lib/gitlab/sidekiq_middleware/metrics.rb b/lib/gitlab/sidekiq_middleware/metrics.rb
index 9588e9ef19a..fbc34357323 100644
--- a/lib/gitlab/sidekiq_middleware/metrics.rb
+++ b/lib/gitlab/sidekiq_middleware/metrics.rb
@@ -10,7 +10,7 @@ module Gitlab
def create_labels(worker_class, queue)
labels = { queue: queue.to_s, latency_sensitive: FALSE_LABEL, external_dependencies: FALSE_LABEL, feature_category: "", boundary: "" }
- return labels unless worker_class.include? WorkerAttributes
+ return labels unless worker_class && worker_class.include?(WorkerAttributes)
labels[:latency_sensitive] = bool_as_label(worker_class.latency_sensitive_worker?)
labels[:external_dependencies] = bool_as_label(worker_class.worker_has_external_dependencies?)