diff options
| author | Lin Jen-Shin <godfat@godfat.org> | 2018-01-09 20:30:04 +0300 |
|---|---|---|
| committer | Lin Jen-Shin <godfat@godfat.org> | 2018-01-12 12:54:55 +0300 |
| commit | 4f00a05152c105814f17a5f582d493435de96747 (patch) | |
| tree | 76eab649b7c832afb47ad3e37ead6eb7a4bdaa93 /lib/gitlab/user_access.rb | |
| parent | 3fde958f36fa9c3bfa30ed1f73108e0640722926 (diff) | |
Introduce PredicateMemoization cop and fix offenses
with StrongMemoize
Diffstat (limited to 'lib/gitlab/user_access.rb')
| -rw-r--r-- | lib/gitlab/user_access.rb | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/gitlab/user_access.rb b/lib/gitlab/user_access.rb index d9a5af09f08..f357488ac61 100644 --- a/lib/gitlab/user_access.rb +++ b/lib/gitlab/user_access.rb @@ -16,8 +16,10 @@ module Gitlab def can_do_action?(action) return false unless can_access_git? - @permission_cache ||= {} - @permission_cache[action] ||= user.can?(action, project) + permission_cache[action] = + permission_cache.fetch(action) do + user.can?(action, project) + end end def cannot_do_action?(action) @@ -88,6 +90,10 @@ module Gitlab private + def permission_cache + @permission_cache ||= {} + end + def can_access_git? user && user.can?(:access_git) end |