diff options
| author | Rémy Coutable <remy@rymai.me> | 2019-09-05 19:50:05 +0300 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-09-05 19:50:05 +0300 |
| commit | 181a9698f4d0fd66f7379bf9927a485f4cb429b9 (patch) | |
| tree | 14d29826ae2c447dc808f1f42128b4994058b5b2 /lib/gitlab | |
| parent | 0e335ec90e7a03e8a6fd3df939de0c647f8a4360 (diff) | |
| parent | 79ec54c39e8ecc397961a8b76dea239e52c7753c (diff) | |
Merge branch 'danger-review-pipeline' into 'master'
Add Danger Roulette rules for pipeline files
See merge request gitlab-org/gitlab-ce!32616
Diffstat (limited to 'lib/gitlab')
| -rw-r--r-- | lib/gitlab/danger/helper.rb | 6 | ||||
| -rw-r--r-- | lib/gitlab/danger/teammate.rb | 2 |
2 files changed, 6 insertions, 2 deletions
diff --git a/lib/gitlab/danger/helper.rb b/lib/gitlab/danger/helper.rb index d30d5a38670..17ad07bfc0c 100644 --- a/lib/gitlab/danger/helper.rb +++ b/lib/gitlab/danger/helper.rb @@ -83,7 +83,8 @@ module Gitlab docs: "~Documentation", # Docs are reviewed along DevOps stages, so don't need roulette for now. none: "", qa: "~QA", - test: "~test for `spec/features/*`" + test: "~test for `spec/features/*`", + engineering_productivity: "Engineering Productivity for CI config review" }.freeze CATEGORIES = { %r{\Adoc/} => :none, # To reinstate roulette for documentation, set to `:docs`. @@ -125,7 +126,8 @@ module Gitlab %r{\A(ee/)?spec/(?!javascripts|frontend)[^/]+} => :backend, %r{\A(ee/)?vendor/(?!assets)[^/]+} => :backend, %r{\A(ee/)?vendor/(languages\.yml|licenses\.csv)\z} => :backend, - %r{\A(Dangerfile|Gemfile|Gemfile.lock|Procfile|Rakefile|\.gitlab-ci\.yml)\z} => :backend, + %r{\A(\.gitlab-ci\.yml\z|\.gitlab\/ci)} => :engineering_productivity, + %r{\A(Dangerfile|Gemfile|Gemfile.lock|Procfile|Rakefile)\z} => :backend, %r{\A[A-Z_]+_VERSION\z} => :backend, %r{\A\.rubocop(_todo)?\.yml\z} => :backend, diff --git a/lib/gitlab/danger/teammate.rb b/lib/gitlab/danger/teammate.rb index 2789706aa3b..4ad66f61c2b 100644 --- a/lib/gitlab/danger/teammate.rb +++ b/lib/gitlab/danger/teammate.rb @@ -42,6 +42,8 @@ module Gitlab area = role[/Test Automation Engineer(?:.*?, (\w+))/, 1] area && labels.any?("devops::#{area.downcase}") if kind == :reviewer + when :engineering_productivity + role[/Engineering Productivity/] if kind == :reviewer else capabilities(project).include?("#{kind} #{category}") end |