diff options
author | Ruben Davila <rdavila84@gmail.com> | 2017-09-07 21:35:45 +0300 |
---|---|---|
committer | Ruben Davila <rdavila84@gmail.com> | 2017-09-07 21:47:58 +0300 |
commit | 62bb6235c229a869052180f9709c4801116f02cc (patch) | |
tree | a28626180edfe5f8abef6e5e2e44a2128c636f49 /lib | |
parent | bc955cfc8e75e17897ab25717176209fefbba915 (diff) |
Make Members with Owner and Master roles always able to create subgroups
Diffstat (limited to 'lib')
-rw-r--r-- | lib/api/groups.rb | 7 | ||||
-rw-r--r-- | lib/api/helpers.rb | 2 |
2 files changed, 7 insertions, 2 deletions
diff --git a/lib/api/groups.rb b/lib/api/groups.rb index 31a918eda60..e817dcbbc4b 100644 --- a/lib/api/groups.rb +++ b/lib/api/groups.rb @@ -74,7 +74,12 @@ module API use :optional_params end post do - authorize! :create_group + parent_group = find_group!(params[:parent_id]) if params[:parent_id].present? + if parent_group + authorize! :create_subgroup, parent_group + else + authorize! :create_group + end group = ::Groups::CreateService.new(current_user, declared_params(include_missing: false)).execute diff --git a/lib/api/helpers.rb b/lib/api/helpers.rb index 8b03df65ae4..00dbc2aee7a 100644 --- a/lib/api/helpers.rb +++ b/lib/api/helpers.rb @@ -93,7 +93,7 @@ module API end def find_group(id) - if id =~ /^\d+$/ + if id.to_s =~ /^\d+$/ Group.find_by(id: id) else Group.find_by_full_path(id) |