Migrate Git::Blob.batch to Gitaly

Closes gitaly#985

3 files changed, 74 insertions, 5 deletions

diff --git a/lib/gitlab/git/blob.rb b/lib/gitlab/git/blob.rb
index 4828301dbb9..b2fca2c16de 100644
--- a/lib/gitlab/git/blob.rb
+++ b/lib/gitlab/git/blob.rb
@@ -53,11 +53,7 @@ module Gitlab
         def batch(repository, blob_references, blob_size_limit: MAX_DATA_DISPLAY_SIZE)
           Gitlab::GitalyClient.migrate(:list_blobs_by_sha_path) do |is_enabled|
             if is_enabled
-              Gitlab::GitalyClient.allow_n_plus_1_calls do
-                blob_references.map do |sha, path|
-                  find_by_gitaly(repository, sha, path, limit: blob_size_limit)
-                end
-              end
+              repository.gitaly_blob_client.get_blobs(blob_references, blob_size_limit).to_a
             else
               blob_references.map do |sha, path|
                 find_by_rugged(repository, sha, path, limit: blob_size_limit)
diff --git a/lib/gitlab/gitaly_client/blob_service.rb b/lib/gitlab/gitaly_client/blob_service.rb
index d70a1a7665e..dfa0fa43b0f 100644
--- a/lib/gitlab/gitaly_client/blob_service.rb
+++ b/lib/gitlab/gitaly_client/blob_service.rb
@@ -1,6 +1,8 @@
 module Gitlab
   module GitalyClient
     class BlobService
+      include Gitlab::EncodingHelper
+
       def initialize(repository)
         @gitaly_repo = repository.gitaly_repository
       end
@@ -54,6 +56,30 @@ module Gitlab
           end
         end
       end
+
+      def get_blobs(revision_paths, limit = -1)
+        return [] if revision_paths.empty?
+
+        revision_paths.map! do |rev, path|
+          Gitaly::GetBlobsRequest::RevisionPath.new(revision: rev, path: encode_binary(path))
+        end
+
+        request = Gitaly::GetBlobsRequest.new(
+          repository: @gitaly_repo,
+          revision_paths: revision_paths,
+          limit: limit
+        )
+
+        response = GitalyClient.call(
+          @gitaly_repo.storage_name,
+          :blob_service,
+          :get_blobs,
+          request,
+          timeout: GitalyClient.default_timeout
+        )
+
+        GitalyClient::BlobsStitcher.new(response)
+      end
     end
   end
 end
diff --git a/lib/gitlab/gitaly_client/blobs_stitcher.rb b/lib/gitlab/gitaly_client/blobs_stitcher.rb
new file mode 100644
index 00000000000..5ca592ff812
--- /dev/null
+++ b/lib/gitlab/gitaly_client/blobs_stitcher.rb
@@ -0,0 +1,47 @@
+module Gitlab
+  module GitalyClient
+    class BlobsStitcher
+      include Enumerable
+
+      def initialize(rpc_response)
+        @rpc_response = rpc_response
+      end
+
+      def each
+        current_blob_data = nil
+
+        @rpc_response.each do |msg|
+          begin
+            if msg.oid.blank? && msg.data.blank?
+              next
+            elsif msg.oid.present?
+              yield new_blob(current_blob_data) if current_blob_data
+
+              current_blob_data = msg.to_h.slice(:oid, :path, :size, :revision, :mode)
+              current_blob_data[:data] = msg.data.dup
+            else
+              current_blob_data[:data] << msg.data
+            end
+          end
+        end
+
+        yield new_blob(current_blob_data) if current_blob_data
+      end
+
+      private
+
+      def new_blob(blob_data)
+        Gitlab::Git::Blob.new(
+          id: blob_data[:oid],
+          mode: blob_data[:mode].to_s(8),
+          name: File.basename(blob_data[:path]),
+          path: blob_data[:path],
+          size: blob_data[:size],
+          commit_id: blob_data[:revision],
+          data: blob_data[:data],
+          binary: Gitlab::Git::Blob.binary?(blob_data[:data])
+        )
+      end
+    end
+  end
+end