diff options
author | Robert Speicher <rspeicher@gmail.com> | 2019-06-29 01:25:25 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2019-06-29 01:25:25 +0300 |
commit | f291aae877bce919f8c2a63cf60f4f3f31482cda (patch) | |
tree | f134ad33129bf3f7daad06045911569e965f60fc /lib | |
parent | df717efaabd9ab11806495244e1e5fa515c01f1f (diff) | |
parent | af28465556c71428f865d1062bbb3931d7d9daff (diff) |
Merge branch 'check-min-schema-migrate' into 'master'
Ensure we are on a supported version before migrating
See merge request gitlab-org/gitlab-ce!29882
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/database.rb | 5 | ||||
-rw-r--r-- | lib/tasks/migrate/schema_check.rake | 20 |
2 files changed, 25 insertions, 0 deletions
diff --git a/lib/gitlab/database.rb b/lib/gitlab/database.rb index 62567be5258..34c1e6ad8ca 100644 --- a/lib/gitlab/database.rb +++ b/lib/gitlab/database.rb @@ -13,6 +13,11 @@ module Gitlab # https://dev.mysql.com/doc/refman/5.7/en/datetime.html MAX_TIMESTAMP_VALUE = Time.at((1 << 31) - 1).freeze + # Minimum schema version from which migrations are supported + # Migrations before this version may have been removed + MIN_SCHEMA_VERSION = 20190506135400 + MIN_SCHEMA_GITLAB_VERSION = '11.11.0' + define_histogram :gitlab_database_transaction_seconds do docstring "Time spent in database transactions, in seconds" end diff --git a/lib/tasks/migrate/schema_check.rake b/lib/tasks/migrate/schema_check.rake new file mode 100644 index 00000000000..76f1f23c7bd --- /dev/null +++ b/lib/tasks/migrate/schema_check.rake @@ -0,0 +1,20 @@ +# frozen_string_literal: true + +# Configures the database by running migrate, or by loading the schema and seeding if needed +task schema_version_check: :environment do + next if ENV['SKIP_SCHEMA_VERSION_CHECK'] + + schema_version = ActiveRecord::Migrator.current_version + + # Ensure migrations are being run from a supported schema version + # A schema verison of 0 is a fresh db, and should be safe to run migrations + # But a database with existing migrations less than our min version is not + if schema_version > 0 && schema_version < Gitlab::Database::MIN_SCHEMA_VERSION + raise "Your current database version is too old to be migrated. " \ + "You should upgrade to GitLab #{Gitlab::Database::MIN_SCHEMA_GITLAB_VERSION} before moving to this version. " \ + "Please see https://docs.gitlab.com/ee/policy/maintenance.html#upgrade-recommendations" + end +end + +# Ensure the check is a pre-requisite when running db:migrate +Rake::Task["db:migrate"].enhance [:schema_version_check] |