diff options
| author | Douwe Maan <douwe@selenight.nl> | 2018-12-20 19:25:48 +0300 |
|---|---|---|
| committer | Douwe Maan <douwe@selenight.nl> | 2019-01-02 17:31:31 +0300 |
| commit | 55723c223f130dc2282cc7c700c590749ad9ad05 (patch) | |
| tree | df492e99715fd7428ef379d1669dbdcbde16e598 /lib | |
| parent | 28cffb9f41836a84d3323e640fe31f92f37bccd9 (diff) | |
Move magic '_any' string to constant
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/git_access.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/gitlab/git_access.rb b/lib/gitlab/git_access.rb index 802fa65dd63..0558bced2c3 100644 --- a/lib/gitlab/git_access.rb +++ b/lib/gitlab/git_access.rb @@ -12,6 +12,10 @@ module Gitlab TimeoutError = Class.new(StandardError) ProjectMovedError = Class.new(NotFoundError) + # Use the magic string '_any' to indicate we do not know what the + # changes are. This is also what gitlab-shell does. + ANY = '_any' + ERROR_MESSAGES = { upload: 'You are not allowed to upload code for this project.', download: 'You are not allowed to download code from this project.', @@ -199,7 +203,7 @@ module Gitlab def ensure_project_on_push!(cmd, changes) return if project || deploy_key? - return unless receive_pack?(cmd) && changes == '_any' && authentication_abilities.include?(:push_code) + return unless receive_pack?(cmd) && changes == ANY && authentication_abilities.include?(:push_code) namespace = Namespace.find_by_full_path(namespace_path) |