diff options
author | Stan Hu <stanhu@gmail.com> | 2019-03-06 21:36:28 +0300 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-03-07 15:29:57 +0300 |
commit | 28883d8e449acc6cb8ad6f0312d77a8ee5027e75 (patch) | |
tree | bb7ba6655708dbdb053530cc2a8f79e26d5faef3 /lib | |
parent | 2c4cb7a6a851d0c49077518a5dd0c289526a66e6 (diff) |
Remove old code in TreeHelper#flatten_tree
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/git/rugged_impl/tree.rb | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/gitlab/git/rugged_impl/tree.rb b/lib/gitlab/git/rugged_impl/tree.rb index c1205bca1d2..f6ddc4e4346 100644 --- a/lib/gitlab/git/rugged_impl/tree.rb +++ b/lib/gitlab/git/rugged_impl/tree.rb @@ -33,9 +33,11 @@ module Gitlab end end - # This is an optimization to reduce N+1 queries for Gitaly. It's - # currently done in TreeHelper#flatten_tree, but to emulate Gitaly - # as much as possible we populate the value here. + # This was an optimization to reduce N+1 queries for Gitaly + # (https://gitlab.com/gitlab-org/gitaly/issues/530). It + # used to be done lazily in the view via + # TreeHelper#flatten_tree, so it's possible there's a + # performance impact by loading this eagerly. rugged_populate_flat_path(repository, sha, path, ordered_entries) end |