diff options
author | Rémy Coutable <remy@rymai.me> | 2018-02-14 17:12:41 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-02-14 17:12:41 +0300 |
commit | 0f27bc5be2837fb35d6e8d5f95101399510d4488 (patch) | |
tree | 69962064f4c0d9939de3b4dabfd21f42201b5c9f /lib | |
parent | 2e8d366da713ea6c8c3d1626c3138fbf2298d28e (diff) | |
parent | 080dba4a7e036e4bcb9cae69c5de6bfa33ff8b2e (diff) |
Merge branch 'mk-fix-pg-undefined-table-ci-errors' into 'master'
Resolve "Build Is Red: Admin > Users > Impersonation Tokens token creation allows creation of a token"
Closes gitlab-ee#4914
See merge request gitlab-org/gitlab-ce!17102
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/background_migration/populate_untracked_uploads.rb | 2 | ||||
-rw-r--r-- | lib/gitlab/background_migration/prepare_untracked_uploads.rb | 6 |
2 files changed, 5 insertions, 3 deletions
diff --git a/lib/gitlab/background_migration/populate_untracked_uploads.rb b/lib/gitlab/background_migration/populate_untracked_uploads.rb index 8a8e770940e..ee55fabd6f0 100644 --- a/lib/gitlab/background_migration/populate_untracked_uploads.rb +++ b/lib/gitlab/background_migration/populate_untracked_uploads.rb @@ -249,7 +249,7 @@ module Gitlab end def drop_temp_table_if_finished - if UntrackedFile.all.empty? + if UntrackedFile.all.empty? && !Rails.env.test? # Dropping a table intermittently breaks test cleanup UntrackedFile.connection.drop_table(:untracked_files_for_uploads, if_exists: true) end diff --git a/lib/gitlab/background_migration/prepare_untracked_uploads.rb b/lib/gitlab/background_migration/prepare_untracked_uploads.rb index 298de005b9b..914a9e48a2f 100644 --- a/lib/gitlab/background_migration/prepare_untracked_uploads.rb +++ b/lib/gitlab/background_migration/prepare_untracked_uploads.rb @@ -171,8 +171,10 @@ module Gitlab end def drop_temp_table - UntrackedFile.connection.drop_table(:untracked_files_for_uploads, - if_exists: true) + unless Rails.env.test? # Dropping a table intermittently breaks test cleanup + UntrackedFile.connection.drop_table(:untracked_files_for_uploads, + if_exists: true) + end end end end |