diff options
author | Aakriti Gupta <agupta@gitlab.com> | 2019-11-06 19:07:11 +0300 |
---|---|---|
committer | Aakriti Gupta <agupta@gitlab.com> | 2019-11-20 12:39:11 +0300 |
commit | 5308314f01ba6415f83018b313233c17bf9cb8a4 (patch) | |
tree | c2d7c3127700ef6978e399e9b1cdbe5ca5974d07 /lib | |
parent | 4d477238500c347c6553d335d920bedfc5a46869 (diff) |
Prevent guests from seeing commits for cycle analytics
- if the user has access level lower than REPORTER,
don't include commit count in summary
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/cycle_analytics/stage_summary.rb | 22 |
1 files changed, 19 insertions, 3 deletions
diff --git a/lib/gitlab/cycle_analytics/stage_summary.rb b/lib/gitlab/cycle_analytics/stage_summary.rb index ea440c441b7..9c75d4bb455 100644 --- a/lib/gitlab/cycle_analytics/stage_summary.rb +++ b/lib/gitlab/cycle_analytics/stage_summary.rb @@ -11,13 +11,29 @@ module Gitlab end def data - [serialize(Summary::Issue.new(project: @project, from: @from, to: @to, current_user: @current_user)), - serialize(Summary::Commit.new(project: @project, from: @from, to: @to)), - serialize(Summary::Deploy.new(project: @project, from: @from, to: @to))] + summary = [issue_stats] + summary << commit_stats if user_has_sufficient_access? + summary << deploy_stats end private + def issue_stats + serialize(Summary::Issue.new(project: @project, from: @from, to: @to, current_user: @current_user)) + end + + def commit_stats + serialize(Summary::Commit.new(project: @project, from: @from, to: @to)) + end + + def deploy_stats + serialize(Summary::Deploy.new(project: @project, from: @from, to: @to)) + end + + def user_has_sufficient_access? + @project.team.member?(@current_user, Gitlab::Access::REPORTER) + end + def serialize(summary_object) AnalyticsSummarySerializer.new.represent(summary_object) end |