Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2017-02-20 22:26:30 +0300
committerRémy Coutable <remy@rymai.me>2017-02-20 22:26:30 +0300
commitfe9cae2618cfb31d86ddc4ae68f45077c236d00b (patch)
treeb46e819ea1ca900d4364bdcd002fac9a1673925c /lib
parent661f377710da81cdd322dc29df52e380b4816c40 (diff)
parentc2426b4eac330a9bfabc7f28f4c7063c69129b3f (diff)
Merge branch '26315-unify-labels-filter-behavior' into 'master'
Unify issues search behavior by always filtering when ALL labels matches Closes #26315 See merge request !8849
Diffstat (limited to 'lib')
-rw-r--r--lib/api/issues.rb14
1 files changed, 3 insertions, 11 deletions
diff --git a/lib/api/issues.rb b/lib/api/issues.rb
index 90fca20d4fa..2b946bfd349 100644
--- a/lib/api/issues.rb
+++ b/lib/api/issues.rb
@@ -10,17 +10,9 @@ module API
args.delete(:id)
args[:milestone_title] = args.delete(:milestone)
+ args[:label_name] = args.delete(:labels)
- match_all_labels = args.delete(:match_all_labels)
- labels = args.delete(:labels)
- args[:label_name] = labels if match_all_labels
-
- issues = IssuesFinder.new(current_user, args).execute.inc_notes_with_associations
-
- # TODO: Remove in 9.0 pass `label_name: args.delete(:labels)` to IssuesFinder
- if !match_all_labels && labels.present?
- issues = issues.includes(:labels).where('labels.title' => labels.split(','))
- end
+ issues = IssuesFinder.new(current_user, args).execute
issues.reorder(args[:order_by] => args[:sort])
end
@@ -77,7 +69,7 @@ module API
get ":id/issues" do
group = find_group!(params[:id])
- issues = find_issues(group_id: group.id, state: params[:state] || 'opened', match_all_labels: true)
+ issues = find_issues(group_id: group.id, state: params[:state] || 'opened')
present paginate(issues), with: Entities::Issue, current_user: current_user
end