diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-12-26 10:34:47 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-04-15 01:26:25 +0300 |
| commit | e675fe4621bc5668d5d9b72961a38be72baf23dd (patch) | |
| tree | cb4c8593d12c0bfa3cc223973052d4a657fb510c /lib | |
| parent | d2d9fb9a863909d1002029ddd19247b52264ab4d (diff) | |
Validate refs used in controllers don't have spaces
This avoids an unnecessary call to Gitaly and reduces gRPC errors.
* Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
* Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58572
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/extracts_path.rb | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/extracts_path.rb b/lib/extracts_path.rb index b2c8d46ede1..44a9c7ea536 100644 --- a/lib/extracts_path.rb +++ b/lib/extracts_path.rb @@ -113,6 +113,9 @@ module ExtractsPath @id = get_id @ref, @path = extract_ref(@id) @repo = @project.repository + @ref.strip! + + raise InvalidPathError if @ref.match?(/\s/) @commit = @repo.commit(@ref) |