diff options
| author | GitLab Release Tools Bot <robert+release-tools@gitlab.com> | 2019-11-26 15:01:56 +0300 |
|---|---|---|
| committer | GitLab Release Tools Bot <robert+release-tools@gitlab.com> | 2019-11-26 15:01:56 +0300 |
| commit | 5f9de1e04140d0a556cd2164ff644ca5fe5c02d2 (patch) | |
| tree | a463261a4a5953e80e8533a1bd14bb423f5dc475 /lib | |
| parent | 70911c7c43f5bc804156c701b3a4ba9b992548b3 (diff) | |
| parent | ad48a55cc22864e97f5a616a3aafc953e8c43ff2 (diff) | |
Merge branch 'security-fix-xss-in-label-namespace-12-5' into '12-5-stable'
Escape namespace in label references
See merge request gitlab/gitlabhq!3550
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/banzai/filter/label_reference_filter.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/banzai/filter/label_reference_filter.rb b/lib/banzai/filter/label_reference_filter.rb index db620c65237..609ea8fb5ca 100644 --- a/lib/banzai/filter/label_reference_filter.rb +++ b/lib/banzai/filter/label_reference_filter.rb @@ -89,7 +89,7 @@ module Banzai parent_from_ref = from_ref_cached(project_path) reference = parent_from_ref.to_human_reference(parent) - label_suffix = " <i>in #{reference}</i>" if reference.present? + label_suffix = " <i>in #{ERB::Util.html_escape(reference)}</i>" if reference.present? end presenter = object.present(issuable_subject: parent) |