Addresses backend/db review comments

- Fixes multiple typos on AutoDevops script
- Add an alias to Clusters::Cluster#domain as base_domain, so it's more
descriptive
- Removes unnecessary memoization on qa specs
- Changes migration to a post migration to deal better with traffic on
big instances (like gitlab.com)

1 files changed, 2 insertions, 8 deletions

diff --git a/qa/qa/resource/kubernetes_cluster.rb b/qa/qa/resource/kubernetes_cluster.rb
index 19c6dc8890d..986b31da528 100644
--- a/qa/qa/resource/kubernetes_cluster.rb
+++ b/qa/qa/resource/kubernetes_cluster.rb
@@ -9,11 +9,11 @@ module QA
         :install_helm_tiller, :install_ingress, :install_prometheus, :install_runner, :domain
 
       attribute :ingress_ip do
-        ingress_ip_value
+        Page::Project::Operations::Kubernetes::Show.perform(&:ingress_ip)
       end
 
       attribute :domain do
-        "#{ingress_ip_value}.nip.io"
+        "#{ingress_ip}.nip.io"
       end
 
       def fabricate!
@@ -56,12 +56,6 @@ module QA
           end
         end
       end
-
-      private
-
-      def ingress_ip_value
-        @ingress_ip_value ||= Page::Project::Operations::Kubernetes::Show.perform(&:ingress_ip)
-      end
     end
   end
 end