diff options
author | Rémy Coutable <remy@rymai.me> | 2018-10-11 20:10:42 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-10-15 15:28:03 +0300 |
commit | 02c47f2f73ac2d5a33b9a6c971668a38397b4910 (patch) | |
tree | b4e9120c8c2592529bbbee6683b926c483fddc3b /rubocop/cop/qa/element_with_pattern.rb | |
parent | 63cd88c668130d22f4a3d708894d0283a5941319 (diff) |
Add a new QA::ElementWithPattern cop
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'rubocop/cop/qa/element_with_pattern.rb')
-rw-r--r-- | rubocop/cop/qa/element_with_pattern.rb | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/rubocop/cop/qa/element_with_pattern.rb b/rubocop/cop/qa/element_with_pattern.rb new file mode 100644 index 00000000000..9d80946f1ba --- /dev/null +++ b/rubocop/cop/qa/element_with_pattern.rb @@ -0,0 +1,39 @@ +require_relative '../../qa_helpers' + +module RuboCop + module Cop + module QA + # This cop checks for the usage of factories in migration specs + # + # @example + # + # # bad + # let(:user) { create(:user) } + # + # # good + # let(:users) { table(:users) } + # let(:user) { users.create!(name: 'User 1', username: 'user1') } + class ElementWithPattern < RuboCop::Cop::Cop + include QAHelpers + + MESSAGE = "Don't use a pattern for element, create a corresponding `%s` instead.".freeze + + def on_send(node) + return unless in_qa_file?(node) + return unless method_name(node).to_s == 'element' + + element_name, pattern = node.arguments + return unless pattern + + add_offense(node, location: pattern.source_range, message: MESSAGE % "qa-#{element_name.value.to_s.tr('_', '-')}") + end + + private + + def method_name(node) + node.children[1] + end + end + end + end +end |