Admin section finds users case-insensitively

Previously, if you entered a username in the URL manually to view a
specific user, the lookup was done case-sensitively, despite usernames
being case-insensitive, often resulting in a 404. We now use the same
`find_routable!` logic as the non-admin Users controller.

1 files changed, 11 insertions, 0 deletions

diff --git a/spec/controllers/admin/users_controller_spec.rb b/spec/controllers/admin/users_controller_spec.rb
index 6b66cbd2651..c934db9e237 100644
--- a/spec/controllers/admin/users_controller_spec.rb
+++ b/spec/controllers/admin/users_controller_spec.rb
@@ -8,6 +8,17 @@ describe Admin::UsersController do
     sign_in(admin)
   end
 
+  describe 'GET :id' do
+    it 'finds a user case-insensitively' do
+      user = create(:user, username: 'CaseSensitive')
+
+      get :show, params: { id: user.username.downcase }
+
+      expect(response).to be_redirect
+      expect(response.location).to end_with(user.username)
+    end
+  end
+
   describe 'DELETE #user with projects' do
     let(:project) { create(:project, namespace: user.namespace) }
     let!(:issue) { create(:issue, author: user) }