diff options
| author | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-06-25 20:54:42 +0300 |
|---|---|---|
| committer | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-07-12 05:15:31 +0300 |
| commit | aeb67dd489b1ccc7f0ab1d702725729ab9cc3e27 (patch) | |
| tree | c508ba9459274be6a8a0488a838d31f03f45faba /spec/controllers/admin | |
| parent | ecffca5d92353d55aaf8f984737fa617782310e0 (diff) | |
Upgrade to Rails 5.2
Updates changed method names and fixes spec failures
Diffstat (limited to 'spec/controllers/admin')
| -rw-r--r-- | spec/controllers/admin/runners_controller_spec.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/spec/controllers/admin/runners_controller_spec.rb b/spec/controllers/admin/runners_controller_spec.rb index 78c5e2a2656..bbeda7dae0f 100644 --- a/spec/controllers/admin/runners_controller_spec.rb +++ b/spec/controllers/admin/runners_controller_spec.rb @@ -23,10 +23,11 @@ describe Admin::RunnersController do control_count = ActiveRecord::QueryRecorder.new { get :index }.count - create(:ci_runner, :tagged_only) + create_list(:ci_runner, 5, :tagged_only) # There is still an N+1 query for `runner.builds.count` - expect { get :index }.not_to exceed_query_limit(control_count + 1) + # We also need to add 1 because it takes 2 queries to preload tags + expect { get :index }.not_to exceed_query_limit(control_count + 6) expect(response).to have_gitlab_http_status(200) expect(response.body).to have_content('tag1') |