diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2018-07-12 17:58:33 +0300 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2018-07-13 17:00:14 +0300 |
| commit | fc9f90045d930641690f75e9bae25683dc67a24e (patch) | |
| tree | 1ffe6c8139ad0a32e558b5dfca797151672cbd56 /spec/controllers/projects/milestones_controller_spec.rb | |
| parent | cfe2121978a235d93d9bacefde37702bfa1f4848 (diff) | |
Escapes milestone title shown in flash message when promoting a milestone
Diffstat (limited to 'spec/controllers/projects/milestones_controller_spec.rb')
| -rw-r--r-- | spec/controllers/projects/milestones_controller_spec.rb | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/controllers/projects/milestones_controller_spec.rb b/spec/controllers/projects/milestones_controller_spec.rb index ea906cf7f32..e351e0fe07d 100644 --- a/spec/controllers/projects/milestones_controller_spec.rb +++ b/spec/controllers/projects/milestones_controller_spec.rb @@ -127,6 +127,14 @@ describe Projects::MilestonesController do expect(flash[:notice]).to eq("#{milestone.title} promoted to <a href=\"#{group_milestone_path(project.group, milestone.iid)}\"><u>group milestone</u></a>.") expect(response).to redirect_to(project_milestones_path(project)) end + + it 'renders milestone name without parsing it as HTML' do + milestone.update!(name: 'CCC<img src=x onerror=alert(document.domain)>') + + post :promote, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid + + expect(flash[:notice]).to eq("CCC<img src=\"x\"> promoted to <a href=\"#{group_milestone_path(project.group, milestone.iid)}\"><u>group milestone</u></a>.") + end end context 'promotion fails' do |