Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrpereira2 <rpereira@gitlab.com>2019-04-03 17:00:22 +0300
committerrpereira2 <rpereira@gitlab.com>2019-04-04 23:42:34 +0300
commit5ee7c419ea97f9322dcaf6da02c85f2ac25f477d (patch)
tree2ad91d1569c69f045d01fd8828ce3725361ce7b8 /spec/controllers
parent16772b91f0b71b47c8e72bfa2d11693aed58e3ba (diff)
Call permit! on params
Diffstat (limited to 'spec/controllers')
-rw-r--r--spec/controllers/projects/environments/prometheus_api_controller_spec.rb15
1 files changed, 14 insertions, 1 deletions
diff --git a/spec/controllers/projects/environments/prometheus_api_controller_spec.rb b/spec/controllers/projects/environments/prometheus_api_controller_spec.rb
index f1ac127fc9e..ee5202ac798 100644
--- a/spec/controllers/projects/environments/prometheus_api_controller_spec.rb
+++ b/spec/controllers/projects/environments/prometheus_api_controller_spec.rb
@@ -14,11 +14,22 @@ describe Projects::Environments::PrometheusApiController do
describe 'GET #proxy' do
let(:prometheus_proxy_service) { instance_double(Prometheus::ProxyService) }
+ let(:expected_params) do
+ ActionController::Parameters.new(
+ "query" => "1",
+ "id" => "1",
+ "namespace_id" => "namespace1",
+ "project_id" => "project1",
+ "proxy_path" => "query",
+ "controller" => "projects/environments/prometheus_api",
+ "action" => "proxy"
+ ).permit!
+ end
context 'with valid requests' do
before do
allow(Prometheus::ProxyService).to receive(:new)
- .with(environment, 'GET', 'query', anything)
+ .with(environment, 'GET', 'query', expected_params)
.and_return(prometheus_proxy_service)
allow(prometheus_proxy_service).to receive(:execute)
@@ -33,6 +44,8 @@ describe Projects::Environments::PrometheusApiController do
it 'returns prometheus response' do
get :proxy, params: environment_params
+ expect(Prometheus::ProxyService).to have_received(:new)
+ .with(environment, 'GET', 'query', expected_params)
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(prometheus_json_body)
end