diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-02 03:06:26 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-02 03:06:26 +0300 |
commit | 587794b4b8a6e919e77ee4abe8215fa291e6a91d (patch) | |
tree | 380d6578d1ab5902bb521071128bafd4f70472ef /spec/controllers | |
parent | e0bd3a45d9dc6c74cac1a33ea8c03d6d8334249b (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/controllers')
24 files changed, 57 insertions, 64 deletions
diff --git a/spec/controllers/admin/clusters_controller_spec.rb b/spec/controllers/admin/clusters_controller_spec.rb index afc059d7561..233710b9fc3 100644 --- a/spec/controllers/admin/clusters_controller_spec.rb +++ b/spec/controllers/admin/clusters_controller_spec.rb @@ -469,7 +469,7 @@ describe Admin::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, :instance) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :instance) } it { expect { put_update }.to be_allowed_for(:admin) } it { expect { put_update }.to be_denied_for(:user) } @@ -531,7 +531,7 @@ describe Admin::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, :instance) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, :instance) } it { expect { delete_destroy }.to be_allowed_for(:admin) } it { expect { delete_destroy }.to be_denied_for(:user) } diff --git a/spec/controllers/admin/requests_profiles_controller_spec.rb b/spec/controllers/admin/requests_profiles_controller_spec.rb index 345f7720c25..853767199bc 100644 --- a/spec/controllers/admin/requests_profiles_controller_spec.rb +++ b/spec/controllers/admin/requests_profiles_controller_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' describe Admin::RequestsProfilesController do - set(:admin) { create(:admin) } + let_it_be(:admin) { create(:admin) } before do sign_in(admin) diff --git a/spec/controllers/admin/users_controller_spec.rb b/spec/controllers/admin/users_controller_spec.rb index d7428f8b52c..28d53a7f830 100644 --- a/spec/controllers/admin/users_controller_spec.rb +++ b/spec/controllers/admin/users_controller_spec.rb @@ -4,7 +4,7 @@ require 'spec_helper' describe Admin::UsersController do let(:user) { create(:user) } - set(:admin) { create(:admin) } + let_it_be(:admin) { create(:admin) } before do sign_in(admin) diff --git a/spec/controllers/groups/clusters_controller_spec.rb b/spec/controllers/groups/clusters_controller_spec.rb index 5a3ba51d4df..51a6dcca640 100644 --- a/spec/controllers/groups/clusters_controller_spec.rb +++ b/spec/controllers/groups/clusters_controller_spec.rb @@ -6,7 +6,7 @@ describe Groups::ClustersController do include AccessMatchersForController include GoogleApi::CloudPlatformHelpers - set(:group) { create(:group) } + let_it_be(:group) { create(:group) } let(:user) { create(:user) } @@ -536,7 +536,7 @@ describe Groups::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group]) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, cluster_type: :group_type, groups: [group]) } it { expect { go }.to be_allowed_for(:admin) } it { expect { go }.to be_allowed_for(:owner).of(group) } @@ -604,7 +604,7 @@ describe Groups::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group]) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, cluster_type: :group_type, groups: [group]) } it { expect { go }.to be_allowed_for(:admin) } it { expect { go }.to be_allowed_for(:owner).of(group) } diff --git a/spec/controllers/groups/labels_controller_spec.rb b/spec/controllers/groups/labels_controller_spec.rb index 98a4c50fc49..d4780fa2675 100644 --- a/spec/controllers/groups/labels_controller_spec.rb +++ b/spec/controllers/groups/labels_controller_spec.rb @@ -3,9 +3,9 @@ require 'spec_helper' describe Groups::LabelsController do - set(:group) { create(:group) } - set(:user) { create(:user) } - set(:project) { create(:project, namespace: group) } + let_it_be(:group) { create(:group) } + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project, namespace: group) } before do group.add_owner(user) @@ -14,8 +14,8 @@ describe Groups::LabelsController do end describe 'GET #index' do - set(:label_1) { create(:label, project: project, title: 'label_1') } - set(:group_label_1) { create(:group_label, group: group, title: 'group_label_1') } + let_it_be(:label_1) { create(:label, project: project, title: 'label_1') } + let_it_be(:group_label_1) { create(:group_label, group: group, title: 'group_label_1') } it 'returns group and project labels by default' do get :index, params: { group_id: group }, format: :json @@ -25,8 +25,8 @@ describe Groups::LabelsController do end context 'with ancestor group' do - set(:subgroup) { create(:group, parent: group) } - set(:subgroup_label_1) { create(:group_label, group: subgroup, title: 'subgroup_label_1') } + let_it_be(:subgroup) { create(:group, parent: group) } + let_it_be(:subgroup_label_1) { create(:group_label, group: subgroup, title: 'subgroup_label_1') } before do subgroup.add_owner(user) diff --git a/spec/controllers/groups/shared_projects_controller_spec.rb b/spec/controllers/groups/shared_projects_controller_spec.rb index 9f6c558c931..a4b2efa7c43 100644 --- a/spec/controllers/groups/shared_projects_controller_spec.rb +++ b/spec/controllers/groups/shared_projects_controller_spec.rb @@ -17,9 +17,9 @@ describe Groups::SharedProjectsController do ).execute(group) end - set(:group) { create(:group) } - set(:user) { create(:user) } - set(:shared_project) do + let_it_be(:group) { create(:group) } + let_it_be(:user) { create(:user) } + let_it_be(:shared_project) do shared_project = create(:project, namespace: user.namespace) share_project(shared_project) diff --git a/spec/controllers/import/bitbucket_server_controller_spec.rb b/spec/controllers/import/bitbucket_server_controller_spec.rb index e1aeab46fca..f30eace7d30 100644 --- a/spec/controllers/import/bitbucket_server_controller_spec.rb +++ b/spec/controllers/import/bitbucket_server_controller_spec.rb @@ -39,7 +39,7 @@ describe Import::BitbucketServerController do assign_session_tokens end - set(:project) { create(:project) } + let_it_be(:project) { create(:project) } it 'returns the new project' do allow(Gitlab::BitbucketServerImport::ProjectCreator) diff --git a/spec/controllers/import/gitlab_projects_controller_spec.rb b/spec/controllers/import/gitlab_projects_controller_spec.rb index 51b398895bc..a3f6d8dcea2 100644 --- a/spec/controllers/import/gitlab_projects_controller_spec.rb +++ b/spec/controllers/import/gitlab_projects_controller_spec.rb @@ -3,8 +3,8 @@ require 'spec_helper' describe Import::GitlabProjectsController do - set(:namespace) { create(:namespace) } - set(:user) { namespace.owner } + let_it_be(:namespace) { create(:namespace) } + let_it_be(:user) { namespace.owner } let(:file) { fixture_file_upload('spec/fixtures/project_export.tar.gz', 'text/plain') } before do diff --git a/spec/controllers/projects/artifacts_controller_spec.rb b/spec/controllers/projects/artifacts_controller_spec.rb index e42e35bc6e0..acc6935cb71 100644 --- a/spec/controllers/projects/artifacts_controller_spec.rb +++ b/spec/controllers/projects/artifacts_controller_spec.rb @@ -4,9 +4,9 @@ require 'spec_helper' describe Projects::ArtifactsController do let(:user) { project.owner } - set(:project) { create(:project, :repository, :public) } + let_it_be(:project) { create(:project, :repository, :public) } - set(:pipeline) do + let_it_be(:pipeline, reload: true) do create(:ci_pipeline, project: project, sha: project.commit.sha, @@ -48,7 +48,7 @@ describe Projects::ArtifactsController do it 'paginates artifacts' do subject - expect(assigns(:artifacts)).to contain_exactly(project.job_artifacts.last) + expect(assigns(:artifacts)).to contain_exactly(project.reload.job_artifacts.last) end end end diff --git a/spec/controllers/projects/autocomplete_sources_controller_spec.rb b/spec/controllers/projects/autocomplete_sources_controller_spec.rb index a9a058e7e17..34765ae3951 100644 --- a/spec/controllers/projects/autocomplete_sources_controller_spec.rb +++ b/spec/controllers/projects/autocomplete_sources_controller_spec.rb @@ -3,10 +3,10 @@ require 'spec_helper' describe Projects::AutocompleteSourcesController do - set(:group) { create(:group) } - set(:project) { create(:project, namespace: group) } - set(:issue) { create(:issue, project: project) } - set(:user) { create(:user) } + let_it_be(:group) { create(:group) } + let_it_be(:project) { create(:project, namespace: group) } + let_it_be(:issue) { create(:issue, project: project) } + let_it_be(:user) { create(:user) } describe 'GET members' do before do diff --git a/spec/controllers/projects/clusters_controller_spec.rb b/spec/controllers/projects/clusters_controller_spec.rb index 8ac72df5d20..e1f6d571d27 100644 --- a/spec/controllers/projects/clusters_controller_spec.rb +++ b/spec/controllers/projects/clusters_controller_spec.rb @@ -7,7 +7,7 @@ describe Projects::ClustersController do include GoogleApi::CloudPlatformHelpers include KubernetesHelpers - set(:project) { create(:project) } + let_it_be(:project) { create(:project) } let(:user) { create(:user) } @@ -536,7 +536,7 @@ describe Projects::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) } it { expect { go }.to be_allowed_for(:admin) } it { expect { go }.to be_allowed_for(:owner).of(project) } @@ -605,7 +605,7 @@ describe Projects::ClustersController do end describe 'security' do - set(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, projects: [project]) } + let_it_be(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, projects: [project]) } it { expect { go }.to be_allowed_for(:admin) } it { expect { go }.to be_allowed_for(:owner).of(project) } diff --git a/spec/controllers/projects/commit_controller_spec.rb b/spec/controllers/projects/commit_controller_spec.rb index afd5cb15e0f..95112cfeabe 100644 --- a/spec/controllers/projects/commit_controller_spec.rb +++ b/spec/controllers/projects/commit_controller_spec.rb @@ -3,9 +3,10 @@ require 'spec_helper' describe Projects::CommitController do - set(:project) { create(:project, :repository) } - set(:user) { create(:user) } - let(:commit) { project.commit("master") } + let_it_be(:project) { create(:project, :repository) } + let_it_be(:user) { create(:user) } + + let(:commit) { project.commit("master") } let(:master_pickable_sha) { '7d3b0f7cff5f37573aea97cebfd5692ea1689924' } let(:master_pickable_commit) { project.commit(master_pickable_sha) } diff --git a/spec/controllers/projects/environments/prometheus_api_controller_spec.rb b/spec/controllers/projects/environments/prometheus_api_controller_spec.rb index 45328482ad7..b12964f8d8b 100644 --- a/spec/controllers/projects/environments/prometheus_api_controller_spec.rb +++ b/spec/controllers/projects/environments/prometheus_api_controller_spec.rb @@ -3,9 +3,9 @@ require 'spec_helper' describe Projects::Environments::PrometheusApiController do - set(:project) { create(:project) } - set(:environment) { create(:environment, project: project) } - set(:user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:environment) { create(:environment, project: project) } + let_it_be(:user) { create(:user) } before do project.add_reporter(user) diff --git a/spec/controllers/projects/environments_controller_spec.rb b/spec/controllers/projects/environments_controller_spec.rb index 50666c8016d..d8e3ea8ba39 100644 --- a/spec/controllers/projects/environments_controller_spec.rb +++ b/spec/controllers/projects/environments_controller_spec.rb @@ -5,10 +5,10 @@ require 'spec_helper' describe Projects::EnvironmentsController do include MetricsDashboardHelpers - set(:user) { create(:user) } - set(:project) { create(:project) } + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project) } - set(:environment) do + let_it_be(:environment) do create(:environment, name: 'production', project: project) end diff --git a/spec/controllers/projects/error_tracking_controller_spec.rb b/spec/controllers/projects/error_tracking_controller_spec.rb index d11ef24ef96..4c224e960a6 100644 --- a/spec/controllers/projects/error_tracking_controller_spec.rb +++ b/spec/controllers/projects/error_tracking_controller_spec.rb @@ -3,8 +3,8 @@ require 'spec_helper' describe Projects::ErrorTrackingController do - set(:project) { create(:project) } - set(:user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:user) { create(:user) } before do sign_in(user) diff --git a/spec/controllers/projects/mirrors_controller_spec.rb b/spec/controllers/projects/mirrors_controller_spec.rb index 51ce9e2544f..fb3dd75460a 100644 --- a/spec/controllers/projects/mirrors_controller_spec.rb +++ b/spec/controllers/projects/mirrors_controller_spec.rb @@ -6,7 +6,7 @@ describe Projects::MirrorsController do include ReactiveCachingHelpers describe 'setting up a remote mirror' do - set(:project) { create(:project, :repository) } + let_it_be(:project) { create(:project, :repository) } context 'when the current project is not a mirror' do it 'allows to create a remote mirror' do diff --git a/spec/controllers/projects/pipeline_schedules_controller_spec.rb b/spec/controllers/projects/pipeline_schedules_controller_spec.rb index 850ef9c92fb..63e2c8a339c 100644 --- a/spec/controllers/projects/pipeline_schedules_controller_spec.rb +++ b/spec/controllers/projects/pipeline_schedules_controller_spec.rb @@ -5,9 +5,9 @@ require 'spec_helper' describe Projects::PipelineSchedulesController do include AccessMatchersForController - set(:user) { create(:user) } - set(:project) { create(:project, :public, :repository) } - set(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project) } + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project, :public, :repository) } + let_it_be(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project) } before do project.add_developer(user) @@ -60,8 +60,6 @@ describe Projects::PipelineSchedulesController do end describe 'GET #new' do - set(:user) { create(:user) } - before do project.add_developer(user) sign_in(user) @@ -77,8 +75,6 @@ describe Projects::PipelineSchedulesController do describe 'POST #create' do describe 'functionality' do - set(:user) { create(:user) } - before do project.add_developer(user) sign_in(user) @@ -149,7 +145,6 @@ describe Projects::PipelineSchedulesController do describe 'PUT #update' do describe 'functionality' do - set(:user) { create(:user) } let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: user) } before do @@ -383,7 +378,6 @@ describe Projects::PipelineSchedulesController do end describe 'POST #play', :clean_gitlab_redis_cache do - set(:user) { create(:user) } let(:ref) { 'master' } before do @@ -442,8 +436,6 @@ describe Projects::PipelineSchedulesController do end describe 'DELETE #destroy' do - set(:user) { create(:user) } - context 'when a developer makes the request' do before do project.add_developer(user) diff --git a/spec/controllers/projects/pipelines_controller_spec.rb b/spec/controllers/projects/pipelines_controller_spec.rb index 212d8b15252..3c2cb9ede40 100644 --- a/spec/controllers/projects/pipelines_controller_spec.rb +++ b/spec/controllers/projects/pipelines_controller_spec.rb @@ -5,7 +5,7 @@ require 'spec_helper' describe Projects::PipelinesController do include ApiHelpers - set(:user) { create(:user) } + let_it_be(:user) { create(:user) } let(:project) { create(:project, :public, :repository) } let(:feature) { ProjectFeature::ENABLED } diff --git a/spec/controllers/projects/pipelines_settings_controller_spec.rb b/spec/controllers/projects/pipelines_settings_controller_spec.rb index 3656b4e3771..16a43f62bd5 100644 --- a/spec/controllers/projects/pipelines_settings_controller_spec.rb +++ b/spec/controllers/projects/pipelines_settings_controller_spec.rb @@ -3,8 +3,8 @@ require 'spec_helper' describe Projects::PipelinesSettingsController do - set(:user) { create(:user) } - set(:project_auto_devops) { create(:project_auto_devops) } + let_it_be(:user) { create(:user) } + let_it_be(:project_auto_devops) { create(:project_auto_devops) } let(:project) { project_auto_devops.project } before do diff --git a/spec/controllers/projects/settings/ci_cd_controller_spec.rb b/spec/controllers/projects/settings/ci_cd_controller_spec.rb index 5bfbcf6eeb5..f4dbfbe15e8 100644 --- a/spec/controllers/projects/settings/ci_cd_controller_spec.rb +++ b/spec/controllers/projects/settings/ci_cd_controller_spec.rb @@ -3,8 +3,8 @@ require('spec_helper') describe Projects::Settings::CiCdController do - set(:user) { create(:user) } - set(:project_auto_devops) { create(:project_auto_devops) } + let_it_be(:user) { create(:user) } + let_it_be(:project_auto_devops) { create(:project_auto_devops) } let(:project) { project_auto_devops.project } before do diff --git a/spec/controllers/projects/settings/operations_controller_spec.rb b/spec/controllers/projects/settings/operations_controller_spec.rb index aa9cd41ed19..3a56511a8d6 100644 --- a/spec/controllers/projects/settings/operations_controller_spec.rb +++ b/spec/controllers/projects/settings/operations_controller_spec.rb @@ -3,8 +3,8 @@ require 'spec_helper' describe Projects::Settings::OperationsController do - set(:user) { create(:user) } - set(:project) { create(:project) } + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project) } before do sign_in(user) diff --git a/spec/controllers/projects/wikis_controller_spec.rb b/spec/controllers/projects/wikis_controller_spec.rb index 6fea6bca4f2..f46da908218 100644 --- a/spec/controllers/projects/wikis_controller_spec.rb +++ b/spec/controllers/projects/wikis_controller_spec.rb @@ -3,8 +3,8 @@ require 'spec_helper' describe Projects::WikisController do - set(:project) { create(:project, :public, :repository) } - set(:user) { project.owner } + let_it_be(:project) { create(:project, :public, :repository) } + let(:user) { project.owner } let(:project_wiki) { ProjectWiki.new(project, user) } let(:wiki) { project_wiki.wiki } let(:wiki_title) { 'page title test' } diff --git a/spec/controllers/projects_controller_spec.rb b/spec/controllers/projects_controller_spec.rb index c732caa6160..ea7dd78329a 100644 --- a/spec/controllers/projects_controller_spec.rb +++ b/spec/controllers/projects_controller_spec.rb @@ -149,7 +149,7 @@ describe ProjectsController do end context 'when the storage is not available', :broken_storage do - set(:project) { create(:project, :broken_storage) } + let_it_be(:project) { create(:project, :broken_storage) } before do project.add_developer(user) diff --git a/spec/controllers/search_controller_spec.rb b/spec/controllers/search_controller_spec.rb index 3e0d53a6573..3dcafae295a 100644 --- a/spec/controllers/search_controller_spec.rb +++ b/spec/controllers/search_controller_spec.rb @@ -67,7 +67,7 @@ describe SearchController do using RSpec::Parameterized::TableSyntax render_views - set(:project) { create(:project, :public, :repository, :wiki_repo) } + let_it_be(:project) { create(:project, :public, :repository, :wiki_repo) } before do expect(::Gitlab::GitalyClient).to receive(:allow_ref_name_caching).and_call_original |