diff options
author | Robert Speicher <rspeicher@gmail.com> | 2015-07-19 00:54:56 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2015-07-19 00:54:56 +0300 |
commit | a364d4260d357c10d45108da8f8ab55426c64fa2 (patch) | |
tree | 2325e5a86fc7e6ebaf0ce49184469ab0e54c431b /spec/controllers | |
parent | 26a9faab25d0dab1a9e126809f5a1bd9dca0a81f (diff) |
Make username parameter for Users#show case-insensitive
Closes #2012
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/users_controller_spec.rb | 35 |
1 files changed, 25 insertions, 10 deletions
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index d47a37914df..9f89101d7f7 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -1,25 +1,38 @@ require 'spec_helper' describe UsersController do - let(:user) { create(:user, username: 'user1', name: 'User 1', email: 'user1@gitlab.com') } - - before do - sign_in(user) - end + let(:user) { create(:user) } describe 'GET #show' do - render_views + it 'is case-insensitive' do + user = create(:user, username: 'CamelCaseUser') + sign_in(user) + + get :show, username: user.username.downcase - it 'renders the show template' do - get :show, username: user.username - expect(response.status).to eq(200) - expect(response).to render_template('show') + expect(response).to be_success + end + + context 'with rendered views' do + render_views + + it 'renders the show template' do + sign_in(user) + + get :show, username: user.username + + expect(response).to be_success + expect(response).to render_template('show') + end end end describe 'GET #calendar' do it 'renders calendar' do + sign_in(user) + get :calendar, username: user.username + expect(response).to render_template('calendar') end end @@ -30,6 +43,8 @@ describe UsersController do before do allow_any_instance_of(User).to receive(:contributed_projects_ids).and_return([project.id]) + + sign_in(user) project.team << [user, :developer] end |