diff options
author | Stan Hu <stanhu@gmail.com> | 2019-06-04 01:04:59 +0300 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-06-04 01:27:24 +0300 |
commit | cfaf012c532a269a230f67b31e623b18e3f8f8b1 (patch) | |
tree | deba08e3288c5b5cb33a457607923989fe8137f2 /spec/controllers | |
parent | 98e1f7d5da8c429e3b8747825e2507bfe464e92c (diff) |
Fix project settings not being able to update
Previously import_url would always be present in the update parameters,
which would cause the validation to fail. We now only include this
parameter only if there is URL given.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62708
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/concerns/import_url_params_spec.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/spec/controllers/concerns/import_url_params_spec.rb b/spec/controllers/concerns/import_url_params_spec.rb index fc5dfb5263f..adbe6e5d3bf 100644 --- a/spec/controllers/concerns/import_url_params_spec.rb +++ b/spec/controllers/concerns/import_url_params_spec.rb @@ -8,6 +8,18 @@ describe ImportUrlParams do controller.import_url_params end + context 'empty URL' do + let(:params) do + ActionController::Parameters.new(project: { + title: 'Test' + }) + end + + it 'returns empty hash' do + expect(import_url_params).to eq({}) + end + end + context 'url and password separately provided' do let(:params) do ActionController::Parameters.new(project: { |